Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AR instead of GCR for Deployments #209

Closed
17 tasks done
NimJay opened this issue Sep 10, 2021 · 1 comment
Closed
17 tasks done

Use AR instead of GCR for Deployments #209

NimJay opened this issue Sep 10, 2021 · 1 comment
Assignees
@NimJay
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@NimJay
Copy link
Collaborator

NimJay commented Sep 10, 2021 •
edited
Loading

We are trying to encourage customers to use AR (Artifact Registry) instead of GCR (Google Container Registry).
So all Deployments in our GKE samples (in this repo) need to use AR-hosted images instead of GCR-hosted images.

Example

For instance, the following hello-app:1.0 Deployment

kubernetes-engine-samples/hello-app/manifests/helloweb-deployment.yaml

Line 35 in 75e3523

image: gcr.io/google-samples/hello-app:1.0
should change to:

image: us-docker.pkg.dev/google-samples/containers/gke/hello-app:1.0

TODOs

Here are the files that need to be updated (and their associated pull-requests):

Concerns

  • Before updating each of the above files, we need to make sure that the associated GKE tutorials still make sense (i.e., if the tutorial contains a step that pushes to GCR, we need to update the tutorial as well).
@NimJay NimJay mentioned this issue Sep 10, 2021
Merged
This was referenced Oct 25, 2021
Merged
Merged
@NimJay NimJay self-assigned this Nov 10, 2021
@NimJay NimJay added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Nov 10, 2021
@askmeegs askmeegs added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Nov 17, 2021
@xtineskim xtineskim mentioned this issue Nov 22, 2021
Merged
This was referenced Nov 24, 2021
Merged
Merged
irvifa added a commit to irvifa/kubernetes-engine-samples that referenced this issue Jan 1, 2022
@irvifa
feat: Use AR instead of GCR on whoami example
1f46946 
    * Please see [Use AR instead of GCR for Deployments GoogleCloudPlatform#209](GoogleCloudPlatform#209).

    * AR = Artifact Registry

    * GCR = Google Container Registry

    * This pull-request for `whereami:v1.2.6`:

    * I'm replacing instances of the images' GCR URLs with the equivalent AR URLs.

      * `gcr.io/google-samples/whereami:v1.2.6` → `us-docker.pkg.dev/google-samples/containers/gke/whereami:v1.2.6`

So once merged, I would have to update the above tutorials via [this Google-internal content publisher](https://devsite.corp.google.com/publisher).

We can verify that the AR (replacement) images and GCR (replaced) images are equivalent like so:

    1. Pull the 2 images you want to compare:

```
docker image pull gcr.io/google-samples/whereami:v1.2.6
docker image pull us-docker.pkg.dev/google-samples/containers/gke/hello-app:2.0
```

    2. Inspecting both images:

```
docker image inspect gcr.io/google-samples/whereami:v1.2.6
docker image inspect us-docker.pkg.dev/google-samples/containers/gke/whereami:v1.2.6
```

    3. See that the [RootFS values match](https://stackoverflow.com/questions/46321878/how-to-verify-if-the-content-of-two-docker-images-is-exactly-the-same/46322160#46322160).
@irvifa irvifa mentioned this issue Jan 1, 2022
Merged
irvifa added a commit to irvifa/kubernetes-engine-samples that referenced this issue Jan 1, 2022
@irvifa
feat: Use AR instead of GCR on whoami example
72b9527 
* Please see [Use AR instead of GCR for Deployments GoogleCloudPlatform#209](GoogleCloudPlatform#209).

    * AR = Artifact Registry

    * GCR = Google Container Registry

    * This pull-request for `whereami:v1.2.6`:

    * I'm replacing instances of the images' GCR URLs with the equivalent AR URLs.

      * `gcr.io/google-samples/whereami:v1.2.6` → `us-docker.pkg.dev/google-samples/containers/gke/whereami:v1.2.6`

So once merged, I would have to update the above tutorials via [this Google-internal content publisher](https://devsite.corp.google.com/publisher).

We can verify that the AR (replacement) images and GCR (replaced) images are equivalent like so:

    1. Pull the 2 images you want to compare:

```
docker image pull gcr.io/google-samples/whereami:v1.2.6
docker image pull us-docker.pkg.dev/google-samples/containers/gke/whereami:v1.2.6
```

    2. Inspecting both images:

```
docker image inspect gcr.io/google-samples/whereami:v1.2.6
docker image inspect us-docker.pkg.dev/google-samples/containers/gke/whereami:v1.2.6
```

    3. See that the [RootFS values match](https://stackoverflow.com/questions/46321878/how-to-verify-if-the-content-of-two-docker-images-is-exactly-the-same/46322160#46322160).
NimJay pushed a commit that referenced this issue Jan 7, 2022
@irvifa
feat: Use AR instead of GCR on whereami example (#259)
99ef0e0 
* Please see [Use AR instead of GCR for Deployments #209](#209).

    * AR = Artifact Registry

    * GCR = Google Container Registry

    * This pull-request for `whereami:v1.2.6`:

    * I'm replacing instances of the images' GCR URLs with the equivalent AR URLs.

      * `gcr.io/google-samples/whereami:v1.2.6` → `us-docker.pkg.dev/google-samples/containers/gke/whereami:v1.2.6`

So once merged, I would have to update the above tutorials via [this Google-internal content publisher](https://devsite.corp.google.com/publisher).

We can verify that the AR (replacement) images and GCR (replaced) images are equivalent like so:

    1. Pull the 2 images you want to compare:

```
docker image pull gcr.io/google-samples/whereami:v1.2.6
docker image pull us-docker.pkg.dev/google-samples/containers/gke/whereami:v1.2.6
```

    2. Inspecting both images:

```
docker image inspect gcr.io/google-samples/whereami:v1.2.6
docker image inspect us-docker.pkg.dev/google-samples/containers/gke/whereami:v1.2.6
```

    3. See that the [RootFS values match](https://stackoverflow.com/questions/46321878/how-to-verify-if-the-content-of-two-docker-images-is-exactly-the-same/46322160#46322160).
@NimJay
Copy link
Collaborator Author

NimJay commented Jan 7, 2022

I am closing this as all Kubernetes Deployments in this repository now use AR samples — instead of GCR samples! 🎈

@NimJay NimJay closed this as completed Jan 7, 2022
@NimJay NimJay mentioned this issue Jan 7, 2022
Merged
mhofstetter added a commit to mhofstetter/cilium that referenced this issue Dec 4, 2023
@mhofstetter
examles: update guestbook example with new image registry
8dd9474 
The GCP Kubernetes Engine Samples migrated their image registry
from Google Container Registry to Google Artifact Registry. Hence,
the image gb-frontend from the guestbook example is no longer available.

Therefore, this commit changes the example to use the new registry.

Issue: GoogleCloudPlatform/kubernetes-engine-samples#209
Guestbook PR: GoogleCloudPlatform/kubernetes-engine-samples#194

Signed-off-by: Marco Hofstetter <[email protected]>
@mhofstetter mhofstetter mentioned this issue Dec 4, 2023
Merged
mhofstetter added a commit to mhofstetter/cilium that referenced this issue Dec 4, 2023
@mhofstetter
examles: update guestbook example with new image registry
3414118 
The GCP Kubernetes Engine Samples migrated their image registry
from Google Container Registry to Google Artifact Registry. Hence,
the image gb-frontend from the guestbook example is no longer available.

Therefore, this commit changes the example to use the new registry.

Issue: GoogleCloudPlatform/kubernetes-engine-samples#209
Guestbook PR: GoogleCloudPlatform/kubernetes-engine-samples#194

Signed-off-by: Marco Hofstetter <[email protected]>
mhofstetter added a commit to mhofstetter/cilium that referenced this issue Dec 4, 2023
@mhofstetter
examples: update guestbook example with new image registry
c4b9554 
The GCP Kubernetes Engine Samples migrated their image registry
from Google Container Registry to Google Artifact Registry. Hence,
the image gb-frontend from the guestbook example is no longer available.

Therefore, this commit changes the example to use the new registry.

Issue: GoogleCloudPlatform/kubernetes-engine-samples#209
Guestbook PR: GoogleCloudPlatform/kubernetes-engine-samples#194

Signed-off-by: Marco Hofstetter <[email protected]>
mhofstetter added a commit to mhofstetter/cilium that referenced this issue Dec 4, 2023
@mhofstetter
examples: update guestbook example with new image registry
6f7fe81 
The GCP Kubernetes Engine Samples migrated their image registry
from Google Container Registry to Google Artifact Registry. Hence,
the image gb-frontend from the guestbook example is no longer available.

Therefore, this commit changes the example to use the new registry.

Issue: GoogleCloudPlatform/kubernetes-engine-samples#209
Guestbook PR: GoogleCloudPlatform/kubernetes-engine-samples#194

Signed-off-by: Marco Hofstetter <[email protected]>
@mhofstetter mhofstetter mentioned this issue Dec 4, 2023
Merged
mhofstetter added a commit to mhofstetter/cilium that referenced this issue Dec 4, 2023
@mhofstetter
examples: update guestbook example with new image registry
4a91581 
The GCP Kubernetes Engine Samples migrated their image registry
from Google Container Registry to Google Artifact Registry. Hence,
the image gb-frontend from the guestbook example is no longer available.

Therefore, this commit changes the example to use the new registry.

Issue: GoogleCloudPlatform/kubernetes-engine-samples#209
Guestbook PR: GoogleCloudPlatform/kubernetes-engine-samples#194

Signed-off-by: Marco Hofstetter <[email protected]>
mhofstetter added a commit to mhofstetter/cilium that referenced this issue Dec 4, 2023
@mhofstetter
examples: update guestbook example with new image registry
8c1ecfb 
The GCP Kubernetes Engine Samples migrated their image registry
from Google Container Registry to Google Artifact Registry. Hence,
the image gb-frontend from the guestbook example is no longer available.

Therefore, this commit changes the example to use the new registry.

Issue: GoogleCloudPlatform/kubernetes-engine-samples#209
Guestbook PR: GoogleCloudPlatform/kubernetes-engine-samples#194

Signed-off-by: Marco Hofstetter <[email protected]>
github-merge-queue bot pushed a commit to cilium/cilium that referenced this issue Dec 5, 2023
@mhofstetter @ti-mo
examples: update guestbook example with new image registry
ffc1db8 
The GCP Kubernetes Engine Samples migrated their image registry
from Google Container Registry to Google Artifact Registry. Hence,
the image gb-frontend from the guestbook example is no longer available.

Therefore, this commit changes the example to use the new registry.

Issue: GoogleCloudPlatform/kubernetes-engine-samples#209
Guestbook PR: GoogleCloudPlatform/kubernetes-engine-samples#194

Signed-off-by: Marco Hofstetter <[email protected]>
github-merge-queue bot pushed a commit to cilium/cilium that referenced this issue Dec 5, 2023
@mhofstetter @ti-mo
examples: update guestbook example with new image registry
c01a860 
The GCP Kubernetes Engine Samples migrated their image registry
from Google Container Registry to Google Artifact Registry. Hence,
the image gb-frontend from the guestbook example is no longer available.

Therefore, this commit changes the example to use the new registry.

Issue: GoogleCloudPlatform/kubernetes-engine-samples#209
Guestbook PR: GoogleCloudPlatform/kubernetes-engine-samples#194

Signed-off-by: Marco Hofstetter <[email protected]>
aanm pushed a commit to cilium/cilium that referenced this issue Dec 5, 2023
@mhofstetter @aanm
examples: update guestbook example with new image registry
888779d 
The GCP Kubernetes Engine Samples migrated their image registry
from Google Container Registry to Google Artifact Registry. Hence,
the image gb-frontend from the guestbook example is no longer available.

Therefore, this commit changes the example to use the new registry.

Issue: GoogleCloudPlatform/kubernetes-engine-samples#209
Guestbook PR: GoogleCloudPlatform/kubernetes-engine-samples#194

Signed-off-by: Marco Hofstetter <[email protected]>
nbusseneau pushed a commit to nbusseneau/cilium that referenced this issue Dec 5, 2023
@mhofstetter @nbusseneau
examples: update guestbook example with new image registry
95af464 
[ upstream commit c01a860 ]

The GCP Kubernetes Engine Samples migrated their image registry
from Google Container Registry to Google Artifact Registry. Hence,
the image gb-frontend from the guestbook example is no longer available.

Therefore, this commit changes the example to use the new registry.

Issue: GoogleCloudPlatform/kubernetes-engine-samples#209
Guestbook PR: GoogleCloudPlatform/kubernetes-engine-samples#194

Signed-off-by: Marco Hofstetter <[email protected]>
Signed-off-by: Nicolas Busseneau <[email protected]>
nbusseneau pushed a commit to cilium/cilium that referenced this issue Dec 5, 2023
@mhofstetter @nbusseneau
examples: update guestbook example with new image registry
0593a8a 
[ upstream commit c01a860 ]

The GCP Kubernetes Engine Samples migrated their image registry
from Google Container Registry to Google Artifact Registry. Hence,
the image gb-frontend from the guestbook example is no longer available.

Therefore, this commit changes the example to use the new registry.

Issue: GoogleCloudPlatform/kubernetes-engine-samples#209
Guestbook PR: GoogleCloudPlatform/kubernetes-engine-samples#194

Signed-off-by: Marco Hofstetter <[email protected]>
Signed-off-by: Nicolas Busseneau <[email protected]>
nbusseneau pushed a commit to cilium/cilium that referenced this issue Dec 5, 2023
@mhofstetter @nbusseneau
examples: update guestbook example with new image registry
78a6cc3 
[ upstream commit c01a860 ]

The GCP Kubernetes Engine Samples migrated their image registry
from Google Container Registry to Google Artifact Registry. Hence,
the image gb-frontend from the guestbook example is no longer available.

Therefore, this commit changes the example to use the new registry.

Issue: GoogleCloudPlatform/kubernetes-engine-samples#209
Guestbook PR: GoogleCloudPlatform/kubernetes-engine-samples#194

Signed-off-by: Marco Hofstetter <[email protected]>
Signed-off-by: Nicolas Busseneau <[email protected]>
nbusseneau pushed a commit to cilium/cilium that referenced this issue Dec 5, 2023
@mhofstetter @nbusseneau
examples: update guestbook example with new image registry
cd971b9 
[ upstream commit c01a860 ]

The GCP Kubernetes Engine Samples migrated their image registry
from Google Container Registry to Google Artifact Registry. Hence,
the image gb-frontend from the guestbook example is no longer available.

Therefore, this commit changes the example to use the new registry.

Issue: GoogleCloudPlatform/kubernetes-engine-samples#209
Guestbook PR: GoogleCloudPlatform/kubernetes-engine-samples#194

Signed-off-by: Marco Hofstetter <[email protected]>
Signed-off-by: Nicolas Busseneau <[email protected]>
nbusseneau pushed a commit to cilium/cilium that referenced this issue Dec 6, 2023
@mhofstetter @nbusseneau
examples: update guestbook example with new image registry
bce145c 
[ upstream commit c01a860 ]

The GCP Kubernetes Engine Samples migrated their image registry
from Google Container Registry to Google Artifact Registry. Hence,
the image gb-frontend from the guestbook example is no longer available.

Therefore, this commit changes the example to use the new registry.

Issue: GoogleCloudPlatform/kubernetes-engine-samples#209
Guestbook PR: GoogleCloudPlatform/kubernetes-engine-samples#194

Signed-off-by: Marco Hofstetter <[email protected]>
Signed-off-by: Nicolas Busseneau <[email protected]>
nbusseneau pushed a commit to cilium/cilium that referenced this issue Dec 6, 2023
@mhofstetter @nbusseneau
examples: update guestbook example with new image registry
89c4104 
[ upstream commit c01a860 ]

The GCP Kubernetes Engine Samples migrated their image registry
from Google Container Registry to Google Artifact Registry. Hence,
the image gb-frontend from the guestbook example is no longer available.

Therefore, this commit changes the example to use the new registry.

Issue: GoogleCloudPlatform/kubernetes-engine-samples#209
Guestbook PR: GoogleCloudPlatform/kubernetes-engine-samples#194

Signed-off-by: Marco Hofstetter <[email protected]>
Signed-off-by: Nicolas Busseneau <[email protected]>
christarazi pushed a commit to cilium/cilium that referenced this issue Dec 6, 2023
@mhofstetter @christarazi
examples: update guestbook example with new image registry
f7d0814 
[ upstream commit c01a860 ]

The GCP Kubernetes Engine Samples migrated their image registry
from Google Container Registry to Google Artifact Registry. Hence,
the image gb-frontend from the guestbook example is no longer available.

Therefore, this commit changes the example to use the new registry.

Issue: GoogleCloudPlatform/kubernetes-engine-samples#209
Guestbook PR: GoogleCloudPlatform/kubernetes-engine-samples#194

Signed-off-by: Marco Hofstetter <[email protected]>
Signed-off-by: Nicolas Busseneau <[email protected]>
pjablonski123 pushed a commit to pjablonski123/cilium that referenced this issue Dec 15, 2023
@mhofstetter @pjablonski123
examples: update guestbook example with new image registry
9577733 
The GCP Kubernetes Engine Samples migrated their image registry
from Google Container Registry to Google Artifact Registry. Hence,
the image gb-frontend from the guestbook example is no longer available.

Therefore, this commit changes the example to use the new registry.

Issue: GoogleCloudPlatform/kubernetes-engine-samples#209
Guestbook PR: GoogleCloudPlatform/kubernetes-engine-samples#194

Signed-off-by: Marco Hofstetter <[email protected]>
@NimJay NimJay mentioned this issue Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NimJay NimJay

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@askmeegs @NimJay