Make condition_prometheus_query_language.evaluation_interval optional (…

…#8564) * Add support for retriggering notifications in AlertPolicy * Add support for forecast options in AlertPolicy * Move tests for forecast alerts into the handwritten file * Add support for PromQL condition type in AlertPolicy * Added test for promql alerts into the handwritten file * Add test for condition_prometheus_query_language.labels * Remove trailing whitespace * Update mmv1/products/monitoring/AlertPolicy.yaml * Make condition_prometheus_query_language.evaluation_interval optional * Remove test for condition_prometheus_query_language.evaluation_interval --------- Co-authored-by: James Edouard <[email protected]> Co-authored-by: Cameron Thornton <[email protected]>
GoogleCloudPlatform · Aug 8, 2023 · 1ea0eda · 1ea0eda
1 parent 7eef4d2
commit 1ea0eda
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/mmv1/products/monitoring/AlertPolicy.yaml b/mmv1/products/monitoring/AlertPolicy.yaml
@@ -852,7 +852,6 @@ properties:
                 default value is zero. Must be zero or positive.
             - !ruby/object:Api::Type::String
               name: evaluationInterval
-              required: true
               description: |
                 How often this rule should be evaluated. Must be a positive multiple
                 of 30 seconds or missing. The default value is 30 seconds. If this

diff --git a/mmv1/third_party/terraform/tests/resource_monitoring_alert_policy_test.go b/mmv1/third_party/terraform/tests/resource_monitoring_alert_policy_test.go
@@ -430,7 +430,6 @@ resource "google_monitoring_alert_policy" "promql" {
     condition_prometheus_query_language {
       query           = "vector(1)"
       duration        = "60s"
-      evaluation_interval = "60s"
       labels = {
         "severity" = "page"
       }