Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make condition_prometheus_query_language.evaluation_interval optional #8564

Merged
merged 14 commits into from
Aug 8, 2023

Conversation

jedouard1994
Copy link
Contributor

Make condition_prometheus_query_language.evaluation_interval optional. The field is not a required field.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

monitoring: updated `evaluation_interval` on `condition_prometheus_query_language` to be optional

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a community contributor. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 10 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 2 files changed, 10 insertions(+), 10 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2931
Passed tests 2629
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change an existing test so that it doesn't specify this value? Sometimes APIs will return a value for a field when the client doesn't set one, which can cause a permadiff in Terraform.

Adding a test where the field is unset should catch that if it's going to happen

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 10 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 3 files changed, 10 insertions(+), 11 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2931
Passed tests 2628
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccMonitoringAlertPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccMonitoringAlertPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}
View the build log or the debug log for each test

@jedouard1994
Copy link
Contributor Author

Thanks for reviewing, changed an existing test to not specify 'evaluation_interval'

@slevenick slevenick merged commit 1ea0eda into GoogleCloudPlatform:main Aug 8, 2023
8 checks passed
jeperetz pushed a commit to jeperetz/magic-modules that referenced this pull request Aug 10, 2023
…GoogleCloudPlatform#8564)

* Add support for retriggering notifications in AlertPolicy

* Add support for forecast options in AlertPolicy

* Move tests for forecast alerts into the handwritten file

* Add support for PromQL condition type in AlertPolicy

* Added test for promql alerts into the handwritten file

* Add test for condition_prometheus_query_language.labels

* Remove trailing whitespace

* Update mmv1/products/monitoring/AlertPolicy.yaml

* Make condition_prometheus_query_language.evaluation_interval optional

* Remove test for condition_prometheus_query_language.evaluation_interval

---------

Co-authored-by: James Edouard <[email protected]>
Co-authored-by: Cameron Thornton <[email protected]>
ron-gal pushed a commit to ron-gal/magic-modules that referenced this pull request Aug 17, 2023
…GoogleCloudPlatform#8564)

* Add support for retriggering notifications in AlertPolicy

* Add support for forecast options in AlertPolicy

* Move tests for forecast alerts into the handwritten file

* Add support for PromQL condition type in AlertPolicy

* Added test for promql alerts into the handwritten file

* Add test for condition_prometheus_query_language.labels

* Remove trailing whitespace

* Update mmv1/products/monitoring/AlertPolicy.yaml

* Make condition_prometheus_query_language.evaluation_interval optional

* Remove test for condition_prometheus_query_language.evaluation_interval

---------

Co-authored-by: James Edouard <[email protected]>
Co-authored-by: Cameron Thornton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants