Update to Go 1.23 #12176
Merged
Update to Go 1.23 #12176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2thorn
reviewed
Oct 31, 2024
|
unit-test-magician error is unrelated to 1.23 upgrade === NAME TestFormatReminderComment/waitingForReview_three_days_with_current_reviewer
scheduled_pr_reminders_test.go:1084:
Error Trace: /home/runner/work/magic-modules/magic-modules/.ci/magician/cmd/scheduled_pr_reminders_test.go:1084
Error: "@SarahFrench This PR has been waiting for review for 3 weekdays. Please take a look! Use the label `disable-review-reminders` to disable these notifications." should not contain "@SarahFrench"
Test: TestFormatReminderComment/waitingForReview_three_days_with_current_reviewer
=== CONT TestFormatReminderComment/waitingForReview_two_weeks
=== CONT TestFormatReminderComment/waitingForMerge_one_week
=== CONT TestFormatReminderComment/waitingForMerge_two_weeks
=== CONT TestFormatReminderComment/waitingForContributor_six_weeks
=== CONT TestFormatReminderComment/waitingForContributor_seven_weeks
=== CONT TestFormatReminderComment/waitingForContributor_four_weeks
=== CONT TestFormatReminderComment/waitingForContributor_28_days
=== CONT TestFormatReminderComment/waitingForReview_one_week
=== CONT TestFormatReminderComment/waitingForContributor_two_weeks
--- FAIL: TestFormatReminderComment (0.00s)
--- PASS: TestFormatReminderComment/waitingForReview_three_days (0.00s)
--- FAIL: TestFormatReminderComment/waitingForReview_three_days_with_current_reviewer (0.00s)
--- PASS: TestFormatReminderComment/waitingForMerge_many_weeks (0.00s)
--- PASS: TestFormatReminderComment/waitingForReview_two_weeks (0.00s)
--- PASS: TestFormatReminderComment/waitingForMerge_one_week (0.00s)
--- PASS: TestFormatReminderComment/waitingForMerge_two_weeks (0.00s)
--- PASS: TestFormatReminderComment/waitingForContributor_six_weeks (0.00s)
--- PASS: TestFormatReminderComment/waitingForContributor_seven_weeks (0.00s)
--- PASS: TestFormatReminderComment/waitingForContributor_four_weeks (0.00s)
--- PASS: TestFormatReminderComment/waitingForContributor_28_days (0.00s)
--- PASS: TestFormatReminderComment/waitingForReview_one_week (0.00s)
--- PASS: TestFormatReminderComment/waitingForContributor_two_weeks (0.00s) |
c2thorn
reviewed
Oct 31, 2024
|
Flagging this as something to resolve first (sorry I missed in the other PR's review): |
c2thorn
approved these changes
Oct 31, 2024
SarahFrench
approved these changes
Oct 31, 2024
This was referenced Nov 1, 2024
Closed
niharika-98
pushed a commit
to niharika-98/magic-modules
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll want to update the wiki also since we recently had the go rewrite https://github.com/hashicorp/terraform-provider-google/wiki/FAQ#-how-do-i-update-the-go-version-used-by-the-terraform-providers-google-and-google-beta
The following will be merged also:
#12175
GoogleCloudPlatform/terraform-google-conversion#2995
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.