Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to go 1.23 #2995

Merged
merged 1 commit into from
Oct 31, 2024
Merged

chore: update to go 1.23 #2995

merged 1 commit into from
Oct 31, 2024

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Oct 29, 2024

A follow up to the PRs for upgrading to go 1.23 in magic-modules

@BBBmau BBBmau requested a review from a team as a code owner October 29, 2024 06:43
@BBBmau BBBmau requested review from melinath and removed request for a team October 29, 2024 06:43
Copy link

conventional-commit-lint-gcf bot commented Oct 29, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@BBBmau BBBmau changed the title chore: update to go 1.22 chore: update to go 1.23 Oct 30, 2024
@melinath
Copy link
Member

/gcbrun

@melinath
Copy link
Member

LGTM assuming tests pass (Though IIRC the license check is safe to ignore in this case if it fails.)

@rileykarson
Copy link
Member

/gcbrun

1 similar comment
@zli82016
Copy link
Member

/gcbrun

@melinath melinath merged commit f4046c5 into GoogleCloudPlatform:main Oct 31, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants