Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing name_pattern -> pattern #1976

Merged
merged 12 commits into from
Jul 11, 2019
Merged

Changing name_pattern -> pattern #1976

merged 12 commits into from
Jul 11, 2019

Conversation

rambleraptor
Copy link
Contributor

I built out name_pattern to have MM automatically convert names to partial self_links.

This pattern can (and should!) be used for other properties in other situations.

I've moved name_pattern over to a property-level field and used it now for Pubsub Topics (name field), Pubsub Subscriptions (name field and topic field), and Source Repositories (name field)

Release Note for Downstream PRs (will be copied)

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 9cf296e.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: modular-magician/ansible#290

@rambleraptor
Copy link
Contributor Author

@SirGitsalot - normal code review
@danawillow - just so you know! If you can think of other TF resources that have weird partial-to-full name patterns, let me know!

@danawillow
Copy link
Contributor

Almost every resource that came into being in the last few years uses this pattern, so sadly not weird.

A few you should look at in more detail to see if they match what you're looking for: accesscontextmanager, binaryauthorization, cloudscheduler, containeranalysis, filestore, redis, resourcemanager, tpu (I did a quick search for name_from_self_link, which is a flattener we tend to use for resources with this pattern)

@rambleraptor
Copy link
Contributor Author

@SirGitsalot ping!

@rambleraptor rambleraptor force-pushed the name-pattern-2 branch 3 times, most recently from 0d8f4f0 to 2a5e0fa Compare July 2, 2019 21:55
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 2a5e0fa.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 113f33a.

Pull request statuses

No diff detected in terraform-provider-google-beta.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
Ansible already has an open PR.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants