-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing name_pattern -> pattern #1976
Conversation
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-provider-google-beta. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
@SirGitsalot - normal code review |
Almost every resource that came into being in the last few years uses this pattern, so sadly not weird. A few you should look at in more detail to see if they match what you're looking for: accesscontextmanager, binaryauthorization, cloudscheduler, containeranalysis, filestore, redis, resourcemanager, tpu (I did a quick search for name_from_self_link, which is a flattener we tend to use for resources with this pattern) |
@SirGitsalot ping! |
0d8f4f0
to
2a5e0fa
Compare
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-provider-google-beta. New Pull RequestsI didn't open any new pull requests because of this PR. |
2a5e0fa
to
113f33a
Compare
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-provider-google-beta. New Pull RequestsI didn't open any new pull requests because of this PR. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
113f33a
to
589093e
Compare
I built out
name_pattern
to have MM automatically convert names to partial self_links.This pattern can (and should!) be used for other properties in other situations.
I've moved name_pattern over to a property-level field and used it now for Pubsub Topics (name field), Pubsub Subscriptions (name field and topic field), and Source Repositories (name field)
Release Note for Downstream PRs (will be copied)