Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for GCP (as of 2019-07-09T06:06:53Z) #59325

Merged
merged 2 commits into from
Jul 23, 2019

Conversation

@ansibot
Copy link
Contributor

ansibot commented Jul 19, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 12 errors:

test/sanity/validate-modules/ignore.txt:737:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_redis_instance.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:738:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_resourcemanager_project.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:739:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_sourcerepo_repository.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:740:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_spanner_database.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:741:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_spanner_instance.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:742:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_sql_database.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:743:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_sql_instance.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:744:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_sql_user.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:745:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_storage_bucket_access_control.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:746:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_storage_bucket.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:747:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_storage_object.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:752:1: A102 Remove since "lib/ansible/modules/cloud/google/gcp_tpu_node.py" passes "E337" test

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jul 19, 2019

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. cloud gce module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Jul 19, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 19, 2019

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 19, 2019
@rambleraptor
Copy link
Contributor

@mattclay please take a look! The Google stuff looks great, but I don't have permission to alter the ignore.txt file.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 22, 2019
@Akasurde Akasurde merged commit 5d412d8 into ansible:devel Jul 23, 2019
@Akasurde Akasurde self-assigned this Jul 23, 2019
@ansible ansible locked and limited conversation to collaborators Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. gce module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants