Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to manage firestore fields #3479

Closed

Conversation

prodaccess
Copy link
Contributor

@prodaccess prodaccess commented May 7, 2020

Release Note Template for Downstream PRs (will be copied)

release-note:enhancement

I'm not sure which release-note to use. either enhancement or new-resource.

One TODO remains, which is to read the proper state of fields to compare and construct the terraform state.

I'd like to get initial reviews to make sure I am on the right track to add the ability to create Single field index via terraform


@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels May 7, 2020
@prodaccess prodaccess marked this pull request as draft May 7, 2020 01:08
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 935 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 935 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 186 insertions(+))

@modular-magician
Copy link
Collaborator

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@SirGitsalot, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 935 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 935 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 186 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 933 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 933 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 186 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 962 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 962 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 189 insertions(+))

@SirGitsalot SirGitsalot requested review from nat-henderson and removed request for SirGitsalot June 9, 2020 18:01
@nat-henderson
Copy link
Contributor

@prodaccess - hi there - did you mean for this to remain a draft? If so, just notify me when you're ready for review!

@prodaccess
Copy link
Contributor Author

Hi, thanks for checking in. Yes, I still need to fix the resource read/update part. I can create and destroy just fine, but terraform show doesn't work as expected. I got sidetracked by #3646.

@nat-henderson
Copy link
Contributor

Hi there - since this has been stale for 6+ months I'm closing it, but do reopen if you ever decide to move it to ready-for-review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants