-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the ability to specify app engine database type #3646
add the ability to specify app engine database type #3646
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @slevenick, please review this PR or find an appropriate assignee. |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=120657" |
Hi @prodaccess, feel free to use hashicorp/terraform-provider-google#6598 as a reference since it was close to complete. |
fa0ca58
to
aa7c426
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found another PR that was doing the same thing: hashicorp/terraform-provider-google#6598. Referenced for more context.
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=121142" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prodaccess Looks good to me! Ran some tests and even tried out CLOUD_FIRESTORE
successfully. Need to look at one more set of tests, and then we should be good to merge.
fixes hashicorp/terraform-provider-google#3657