Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the ability to specify app engine database type #3646

Merged

Conversation

prodaccess
Copy link
Contributor

@prodaccess prodaccess commented Jun 16, 2020

fixes hashicorp/terraform-provider-google#3657

app_engine: added the option to specify `database_type` in `google_app_engine_application`

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 16 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 16 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=120657"

@c2thorn
Copy link
Member

c2thorn commented Jun 17, 2020

Hi @prodaccess, feel free to use hashicorp/terraform-provider-google#6598 as a reference since it was close to complete.

Copy link
Contributor Author

@prodaccess prodaccess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found another PR that was doing the same thing: hashicorp/terraform-provider-google#6598. Referenced for more context.

@prodaccess prodaccess marked this pull request as ready for review June 17, 2020 19:35
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 16 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 16 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=121142"

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prodaccess Looks good to me! Ran some tests and even tried out CLOUD_FIRESTORE successfully. Need to look at one more set of tests, and then we should be good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring Firestore on a project with Terraform
4 participants