-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream TPG #6920. #3833
Upstream TPG #6920. #3833
Conversation
products/bigquery/api.yaml
Outdated
@@ -549,7 +551,7 @@ objects: | |||
description: | | |||
Specifies whether to use BigQuery's legacy SQL dialect for this query. The default value is true. | |||
If set to false, the query will use BigQuery's standard SQL. | |||
default_value: true | |||
send_if_empty: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be send_empty_value
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, was too quick to approve! Looks like the build broke, and I took a further look.
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 9 insertions(+), 6 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=138110" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerClusterDatasource_regional|TestAccContainerClusterDatasource_zonal|TestAccBigQueryJob_bigqueryJobQueryExample|TestAccBigQueryJob_bigqueryJobQueryTableReferenceExample|TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample|TestAccCloudBuildTrigger_basic|TestAccComputeInstanceTemplate_shieldedVmConfig1|TestAccComputeInstanceTemplate_shieldedVmConfig2|TestAccComputeInstance_shieldedVmConfig1|TestAccComputeInstance_shieldedVmConfig2|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccContainerCluster_basic|TestAccContainerCluster_misc|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_withInvalidReleaseChannel|TestAccContainerCluster_withAddons|TestAccContainerCluster_withMasterAuthConfig_NoCert|TestAccContainerCluster_withMasterAuthConfig|TestAccContainerCluster_withNetworkPolicyEnabled|TestAccContainerCluster_regionalWithNodeLocations|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_regional|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_withVersion|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerCluster_withNodeConfig|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerCluster_backend|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_network|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withNodePoolConflictingNameFields|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerCluster_withShieldedNodes|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_errorNoClusterCreated|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerNodePool_nodeLocations|TestAccContainerNodePool_withNodeConfig|TestAccContainerNodePool_basic|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_withManagement|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_regionalClusters|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_resize|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_shieldedInstanceConfig|TestAccEndpointsService_basic|TestAccFolderIamAuditConfig_multiple|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_redisInstancePrivateServiceExample|TestAccSqlDatabaseInstance_dontDeleteDefaultUserOnReplica|TestAccSqlDatabaseInstance_settings_basic|TestAccSqlDatabaseInstance_replica|TestAccSqlDatabaseInstance_slave|TestAccSqlDatabaseInstance_highAvailability|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_basic_with_user_labels You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=138115" |
Upstreams hashicorp/terraform-provider-google#6920 and therefore fixes
hashicorp/terraform-provider-google#6875 and hashicorp/terraform-provider-google#6231.
Release Note Template for Downstream PRs (will be copied)