Fix google_bigquery_job to use_legacy_sql as configured in resource, add note in docs on how to run DML queries successfully #6920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 3, 2020 11:17
* upstream/master: Add a random string to ad directory so tests can be run in parallel (hashicorp#3802) (hashicorp#6905) Set context early on in LoadAndValidate to prevent NPE (hashicorp#3800) (hashicorp#6903) Add tests for DICOM store pubsub topic removal. (hashicorp#3442) (hashicorp#6893) Bump Bigtable version from 1.1.0 to 1.5.0 (hashicorp#6890) Fix colon in doc notes (hashicorp#3796) (hashicorp#6888) Fix bug: diff being detected for source_repo_repository even when there are no changes (hashicorp#3786) (hashicorp#6886) Use proper prefix inside router_interface test (hashicorp#3795) (hashicorp#6883) Update Bigtable Num of Clusters Block Docs (hashicorp#3792) (hashicorp#6881)
ghost
requested review from
dboshardy
changed the title
|
Thanks for your contribution. This is generated code, so I have made the changes to the generation config that should generate this code in GoogleCloudPlatform/magic-modules#3833. |
|
Great, I've merged this in upstream. |
modular-magician
added a commit
to modular-magician/terraform-provider-google
that referenced
this pull request
Aug 12, 2020
Signed-off-by: Modular Magician <[email protected]>
Merged
modular-magician
added a commit
that referenced
this pull request
Aug 12, 2020
Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6875 and #6231.
It removes the check if empty which incorrectly handles
falsebool values. It also adds a note to the docs that DML queries must specifycreate_disposition = ""andwrite_disposition = "".