Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop editing the global config object with new useragent entries #4123

Merged
merged 4 commits into from
Oct 19, 2020

Conversation

rileykarson
Copy link
Member

@rileykarson rileykarson commented Oct 16, 2020

It looks like some occurrences of this were left in after #4016. This means we'd keep appending onto the end of it while a single provider instance was alive, possibly causing issues in large applies.

Also don't append to the user agent if the m.ModuleName value is nil or empty- we would have added a space every time generateUserAgentString was called.

Notably, this breaks module attribution for batched requests. I'm pretty comfortable with that- it just affects service management and IAM, and we can fix them in a followup.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

provider: fixed an issue where the request headers would grow proportionally to the number of resources in a given `terraform apply`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 170 files changed, 8 insertions(+), 301 deletions(-))
Terraform Beta: Diff ( 195 files changed, 8 insertions(+), 350 deletions(-))
TF Conversion: Diff ( 1 file changed, 5 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=152605"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 170 files changed, 8 insertions(+), 301 deletions(-))
Terraform Beta: Diff ( 195 files changed, 8 insertions(+), 350 deletions(-))
TF Conversion: Diff ( 1 file changed, 5 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=152613"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 170 files changed, 8 insertions(+), 301 deletions(-))
Terraform Beta: Diff ( 195 files changed, 8 insertions(+), 350 deletions(-))
TF Conversion: Diff ( 1 file changed, 5 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=152616"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 173 files changed, 8 insertions(+), 449 deletions(-))
Terraform Beta: Diff ( 198 files changed, 8 insertions(+), 498 deletions(-))
TF Conversion: Diff ( 1 file changed, 5 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=153002"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants