Stop editing the global config object with new useragent entries #7576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like some occurrences of this were left in after GoogleCloudPlatform/magic-modules#4016. This means we'd keep appending onto the end of it while a single provider instance was alive, possibly causing issues in large applies.
Also don't append to the user agent if the
m.ModuleName
value is nil or empty- we would have added a space every timegenerateUserAgentString
was called.Notably, this breaks module attribution for batched requests. I'm pretty comfortable with that- it just affects service management and IAM, and we can fix them in a followup.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#4123