-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PSQL 13 to docs and change defaults on SQL Version field #4210
Conversation
Fork Update
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @c2thorn, please review this PR or find an appropriate assignee. |
I'm aware that this change might cause issues for the 0.0001 % of terraform users who forgot to specify mysql5.6 as their version and now need to set the field. There is a fat warning here about the API being in beta and receiving backward incompatible changes. I changed the default because google is currently defaulting to 5.7 which you can verify by running
|
Fixes points to the correct issue now |
Yeah, make it required. It makes the resource less fragile. |
Thanks @upodroid. |
Fixes hashicorp/terraform-provider-google#7772
Fixes hashicorp/terraform-provider-google#5212
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)