Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make google_sql_database_instance version required #5212

Closed
rileykarson opened this issue Dec 17, 2019 · 2 comments · Fixed by GoogleCloudPlatform/magic-modules#5337, terraform-google-modules/docs-examples#174, hashicorp/terraform-provider-google-beta#3770 or #10398
Closed

Make google_sql_database_instance version required #5212

rileykarson opened this issue Dec 17, 2019 · 2 comments · Fixed by GoogleCloudPlatform/magic-modules#5337, terraform-google-modules/docs-examples#174, hashicorp/terraform-provider-google-beta#3770 or #10398
Assignees
@shuyama1
Labels
breaking-change size/s
Milestone
4.0.0

Comments

@rileykarson
Copy link
Collaborator

rileykarson commented Dec 17, 2019 •
edited
Loading

We've drifted from the API default of MySQL 5.7 (we're still on 5.6) and eventually 5.6 will be deprecated. Admittedly, there's no concrete timeline and we will have a 12mo window: https://cloud.google.com/sql/docs/mysql/db-versions#major_version_deprecation_plan

With 3 DB types (MySQL, Postgres, SQL Server) and an old default version, I think it's time we make the field Required.
@danawillow danawillow added this to the 4.0.0 milestone Jan 6, 2020
@c2thorn c2thorn mentioned this issue Sep 15, 2021
Closed
@upodroid upodroid mentioned this issue Sep 15, 2021
Closed
5 tasks
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Sep 17, 2021
@modular-magician
update comment to generate downstreams (hashicorp#5212)
19e2f20 
Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit that referenced this issue Sep 17, 2021
@modular-magician
update comment to generate downstreams (#5212) (#10098)
0800026 
Signed-off-by: Modular Magician <[email protected]>
@shuyama1 shuyama1 self-assigned this Sep 28, 2021
@shuyama1 shuyama1 mentioned this issue Oct 18, 2021
Merged
5 tasks
@rileykarson
Copy link
Collaborator Author

Marking as 4.0.0-ready given this doesn't seem to need any 3.X changes.

This was referenced Oct 25, 2021
Merged
Merged
Merged
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shuyama1 shuyama1

Labels
breaking-change size/s
Projects
None yet
Milestone
4.0.0
4 participants
@danawillow @rileykarson @c2thorn @shuyama1