Adds support for Graceful Updater in Compute Managed Instance Groups.

[gsancewicz]

Fixes hashicorp/terraform-provider-google#9153

Adds support for Graceful Updater in Compute Managed Instance Groups.

Logic in previous pull request was not forcing sending empty fields and it was reverted.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  I was not able to run acceptance tests today since my local test environment is currently unavailable. I'm hoping that the pull request will trigger acceptance tests.
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added field `update_policy.most_disruptive_allowed_action` to `google_compute_instance_group_manager` and `google_compute_region_instance_group_manager`

compute: added value `REFRESH` to field update_policy.minimal_action` in `google_compute_instance_group_manager` and `google_compute_region_instance_group_manager`

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @melinath, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[gsancewicz]

@slevenick Sam, thank you for your reviews in the previous PR. Could you PTAL at this one as well?

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 55 insertions(+), 30 deletions(-))
Terraform Beta: Diff ( 6 files changed, 57 insertions(+), 32 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1986
Passed tests 1744
Skipped tests: 240
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

[modular-magician]

Tests passed during RECORDING mode:
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view]
TestAccFirebaserulesRelease_BasicRelease[view]

All tests passed
View the build log or the debug log for each test

[gsancewicz]

/gcbrun

[melinath]

tentatively reassigning to slevenick since it sounds like there may be context here. Feel free to assign back to me if needed.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 82 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 6 files changed, 83 insertions(+), 35 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[gsancewicz]

I added new commits with changes:

• changed ForceSendFields to NullFields in case when the field is not set. Difference in behavior is that if will send null instead of empty string
• minimal_action is not optional field with the default value REPLACE. REST Api behavior - minimal_action is optional but if it is not set it is set to REPLACE in the backend.

[modular-magician]

Tests analytics

Total tests: 1993
Passed tests 1749
Skipped tests: 241
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease|TestAccComputeRegionPerInstanceConfig_update|TestAccRegionInstanceGroupManager_stateful

[modular-magician]

Tests passed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[view]
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccComputeRegionPerInstanceConfig_update[view]

All tests passed
View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 82 insertions(+), 34 deletions(-))
Terraform Beta: Diff ( 6 files changed, 83 insertions(+), 35 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1995
Passed tests 1753
Skipped tests: 241
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[view]

All tests passed
View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 65 insertions(+), 29 deletions(-))
Terraform Beta: Diff ( 6 files changed, 66 insertions(+), 30 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2002
Passed tests 1758
Skipped tests: 242
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease|TestAccComputeForwardingRule_update

[modular-magician]

Tests passed during RECORDING mode:
TestAccComputeForwardingRule_update[view]
TestAccFirebaserulesRelease_BasicRelease[view]

All tests passed
View the build log or the debug log for each test