Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for Graceful Updater in Compute Managed Instance Groups. #11640

Conversation

modular-magician
Copy link
Collaborator

Fixes #9153

Adds support for Graceful Updater in Compute Managed Instance Groups.

Logic in previous pull request was not forcing sending empty fields and it was reverted.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
    I was not able to run acceptance tests today since my local test environment is currently unavailable. I'm hoping that the pull request will trigger acceptance tests.
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added field `update_policy.most_disruptive_allowed_action` to `google_compute_instance_group_manager` and `google_compute_region_instance_group_manager`
compute: added value `REFRESH` to field update_policy.minimal_action` in `google_compute_instance_group_manager` and `google_compute_region_instance_group_manager`

Derived from GoogleCloudPlatform/magic-modules#5975

…hashicorp#5975)

* Support new features of IGM.updatePolicy (hashicorp#4956)

* Add new IGM.UpdatePolicy features - minimal_action=REFRESH and most_disruptive_allowed_action

* Fix documentation of most_disruptive_allowed_action

* Make most_disruptive_allowed_action an Optional field.

* Fix RMIG UpdatePolicy flattening.

* Fix most_disruptive_allowed_action documentation - new field is Optional.

* Fix most_disruptive_allowed_action documentation - and improve testing.

* Fix whitespaces in test.

Co-authored-by: Grzegorz Sancewicz <[email protected]>

* Always send minimal_action and most_disruptive_allowed_action with IGM.UpdatePolicy.

* Make minimal_action optional and send null values instead of empty strings

* Remove unnecesary appending to ForceSendFields array

* Fix documentation for minimal_action - field is no longer required.

* Revert making minimal_action optional.

Co-authored-by: Kamil Hajduczenia <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit a2f013f into hashicorp:main May 4, 2022
@github-actions
Copy link

github-actions bot commented Jun 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for google_compute_instance_group_manager Graceful Updater (beta)
1 participant