Add version retention period to Spanner database resource #6141

SarahFrench · 2022-06-16T19:17:04Z

Description

Fixes hashicorp/terraform-provider-google#8994

This PR lets Terraform users set the retention period of historical versions of a Spanner database's data and schema for point in time recovery (PITR).

The retention period of the data used for PITR can be changed by running a DDL statement to update the database's options:

-- Google Standard SQL
ALTER DATABASE `example-db` SET OPTIONS (version_retention_period="7d";

-- Postgres
ALTER DATABASE `example-db` SET spanner.version_retention_period TO "7d";

See usage notes section here & docs about equivalent DDL for Postgres

These DDL statements can be sent through the REST API and executed at either:

Creation of a new database via the create endpoint
- as an entry in the extraStatements array in the request body
- ⚠️ not allowed for Postgres ⚠️
  - If you provide any extraStatements in the create request for a Postgres database, you get this error: DDL statements other than <CREATE DATABASE> are not allowed in database creation request for PostgreSQL-enabled databases
Updating a database via the updateDdl endpoint
- OK for both database dialects

Approach

I've used the value of the version_retention_period field to create an ALTER DDL statement like above and add it to the array of statements in the request bodies of requests sent to the create or updateDdl endpoints

Edit 2022-06-27 : I refactored the code for creating databases so that DDL statements (both originating from ddl and version_retention_period fields) are executed in the database via a separate API call. After the database is made using the create endpoint the provider runs DDL against the new database using the updateDdl endpoint, all within the creation process in Terraform.

Postgres issues

The DDL restriction when making Postgres databases has been met by the initial version of this PR by skipping setting the retention time during creation, even if the version_retention_period is set in the Terraform configuration. When a plan is generated a 2nd time from the Terraform configuration it will plan to update the retention time on the Postgres DB.

~~This might be confusing to practitioners, but seems like the need to re-apply plans for Postgres databases isn't new and is mentioned in the docs.~~

Edit 2022-06-27 : By separating all execution of DDL into an API call separate to the initial create API call this means Postgres's limitations in Spanner don't require 2nd apply steps

Open questions

How does this approach work with acceptance tests, which try to prevent scenarios where 2nd plans from the same config contain changes still. Is that a sign that this should be approached differently?
Would a more explicit error that disallows version_retention_period being set before making the Postgres DB be better? That would avoid the confusion of needing to apply a plan twice to reach the desired goal
Should there be any protection against users setting the retention time via an ALTER statement in the ddl parameter of the Terraform provider? The only issue would be if someone added version_retention_period to their config but then resumed setting it via ddl (version_retention_period would always re-assert itself on the next plan&apply)

PR steps

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

spanner: Added field `version_retention_period` to `google_spanner_database` resource

spanner: Fixed issue where `ddl` and `version_retention_period` could not be set when first creating `google_spanner_database` using POSTGRESQL

google-cla · 2022-06-16T19:17:09Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

modular-magician · 2022-06-16T19:17:20Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2022-06-16T19:18:04Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @c2thorn, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2022-06-16T19:20:06Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2022-06-16T19:32:45Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 191 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 191 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 81 insertions(+), 4 deletions(-))

modular-magician · 2022-06-16T20:17:16Z

Tests analytics

Total tests: 2053
Passed tests 1820
Skipped tests: 226
Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

modular-magician · 2022-06-16T20:42:38Z

Tests passed during RECORDING mode:
TestAccSpannerDatabaseIamMember[view]
TestAccSpannerDatabase_basic[view]
TestAccSpannerDatabaseIamPolicy[view]
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccSpannerDatabaseIamBinding[view]

Tests failed during RECORDING mode:
TestAccContainerCluster_withAddons[view]
TestAccContainerCluster_withConfidentialNodes[view]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-06-17T18:55:37Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2022-06-17T19:04:14Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2022-06-17T19:14:42Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 212 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 6 files changed, 212 insertions(+), 20 deletions(-))
TF Validator: Diff ( 3 files changed, 81 insertions(+), 4 deletions(-))

…ource

Regex previously didn't allow time periods of less than a day, but times of >1hour are valid in the API

SarahFrench · 2022-06-17T19:45:13Z

Squashed a couple of my commits together to clean up the PR and accidentally removed the link between commits & modular-magician output - sorry about that! 😅

When I first made the PR I wasn't sure to handle how the new field cannot be set when creating a new Postgres DB. In this PR I've included ways that side-step this restriction in the API, but as the same isn't done for ddl and the API error is returned. Maybe I should simplify this PR to follow suit? My motivation for doing it in a different way was that the API error is easily connected to the ddl property as it mentions DDL, but some may not realise that the new field is just another DDL statement under the hood

modular-magician · 2022-06-17T19:45:44Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 215 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 7 files changed, 215 insertions(+), 20 deletions(-))
TF Validator: Diff ( 3 files changed, 81 insertions(+), 4 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+))

modular-magician · 2022-06-17T20:31:43Z

Tests analytics

Total tests: 2053
Passed tests 1823
Skipped tests: 226
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons|TestAccSpannerDatabase_postgres

modular-magician · 2022-06-17T20:55:37Z

Tests passed during RECORDING mode:
TestAccSpannerDatabase_postgres[view]
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccContainerCluster_withAddons[view]
TestAccContainerCluster_withConfidentialNodes[view]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-06-20T15:43:10Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 215 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 7 files changed, 215 insertions(+), 20 deletions(-))
TF Validator: Diff ( 3 files changed, 81 insertions(+), 4 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+))

modular-magician · 2022-06-20T16:25:01Z

Tests analytics

Total tests: 2053
Passed tests 1820
Skipped tests: 226
Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

modular-magician · 2022-06-20T16:51:20Z

Tests passed during RECORDING mode:
TestAccSpannerDatabaseIamMember[view]
TestAccSpannerDatabase_basic[view]
TestAccSpannerDatabaseIamPolicy[view]
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccSpannerDatabaseIamBinding[view]

Tests failed during RECORDING mode:
TestAccContainerCluster_withAddons[view]
TestAccContainerCluster_withConfidentialNodes[view]

Please fix these to complete your PR
View the build log or the debug log for each test

c2thorn

only minor asks, looks great overall. I'll address the open questions in another comment

c2thorn · 2022-06-21T20:28:50Z

mmv1/products/spanner/api.yaml

+          and 7 days, and can be specified in days, hours, minutes, or seconds. For example,
+          the values 1d, 24h, 1440m, and 86400s are equivalent. Default value is 1h.
+          If this property is used, you must avoid adding new DDL statements to `ddl` that
+          update the database's version_retention_period. 


Can we add a note similar to what database_dialect has for the double-apply limitation?

mmv1/products/spanner/api.yaml

mmv1/templates/terraform/constants/spanner_database.go.erb

mmv1/templates/terraform/encoders/spanner_database.go.erb

c2thorn · 2022-06-21T21:53:41Z

mmv1/templates/terraform/encoders/spanner_database.go.erb

+        obj["extraStatements"] = extraStatements
+}
+if retentionPeriodOk && dialect == "POSTGRESQL" {
+    // DDL statements other than <CREATE DATABASE> are not allowed in database creation request for PostgreSQL-enabled databases


I think it's possible to have a post-create function that waits for the resource to be created and then calls an update to set the retention period and dialect fields. This would mean two API requests in one apply, and should be a better UX unless I am missing something.

Looking at this earlier conversation it seems like this limitation was acknowledged and may be addressed in the future. Based on precedent, I think it is fine to leave as-is for now.

Thanks for this comment - I'm new to magic-modules and wasn't aware of things like post_create code blocks that I could set. I had a chat with @megan07 and decided to try out moving all the DDL (originating from ddl or version_retention_period) into a post_create block that calls the updateDdl endpoint after the DB is first made via the create endpoint.

This means that this PR has also refactored how the ddl field is handled, but I think that it's preferable to have the control flow the same regardless of database dialect and only use dialect == "POSTGRESQL" to control the SQL syntax when statements are prepared.

It also means that Postgres DBs can be added in a Terraform config with DDL set and that config doesn't need to be applied multiple times to get to the end result. I've updated tests to reflect this, and removed warnings from the documentation.

(Added in commit 3b78b94)

c2thorn · 2022-06-21T22:20:49Z

How does this approach work with acceptance tests, which try to prevent scenarios where 2nd plans from the same config contain changes still.

We would ignore the field when verifying the create step like here: https://github.com/GoogleCloudPlatform/magic-modules/pull/5799/files#diff-bc14ae2ed214f27590f8fe2a8106235c9dee0fca59f31608041d97e025b257c8R143
Not needed in your test since it is going to the default during create and updating later.

Is that a sign that this should be approached differently?

Yep, but isn't too rare. Also see #6141 (comment)

Would a more explicit error that disallows version_retention_period being set before making the Postgres DB be better? That would avoid the confusion of needing to apply a plan twice to reach the desired goal

It's hard for me to tell if it's better to try to warn users up front vs the convenience of not having to edit the config twice. Many users run Terraform effectively in a terraform apply loop (against recommendation of course) which the error would hinder. If anything, I defer to the precedent set by #5799

Should there be any protection against users setting the retention time via an ALTER statement in the ddl parameter of the Terraform provider? The only issue would be if someone added version_retention_period to their config but then resumed setting it via ddl (version_retention_period would always re-assert itself on the next plan&apply)

That feels like a minor enough use case to not warrant the effort + maintenance, but let me know if you think otherwise. If they wanted to resume setting it via ddl, they would just need to remove the version_retention_period field right?

Co-authored-by: Cameron Thornton <[email protected]>

modular-magician · 2022-06-22T19:19:35Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 215 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 7 files changed, 215 insertions(+), 20 deletions(-))
TF Validator: Diff ( 3 files changed, 81 insertions(+), 4 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+))

modular-magician · 2022-06-22T20:01:19Z

Tests analytics

Total tests: 2053
Passed tests 1824
Skipped tests: 226
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons

modular-magician · 2022-06-22T20:24:40Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccContainerCluster_withAddons[view]
TestAccContainerCluster_withConfidentialNodes[view]

Please fix these to complete your PR
View the build log or the debug log for each test

Instead of DB dialect-specific logic, move all setting of DDL to a post-create, using updateDdl endpoint. Remove notes in documentation mentioning re-applying Terraform

modular-magician · 2022-06-27T14:46:26Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 266 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 7 files changed, 266 insertions(+), 32 deletions(-))
TF Validator: Diff ( 3 files changed, 62 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+))

modular-magician · 2022-06-27T15:36:06Z

Tests analytics

Total tests: 2054
Passed tests 1824
Skipped tests: 226
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons|TestAccSpannerDatabase_basic|TestAccSpannerDatabase_postgres

modular-magician · 2022-06-27T16:03:16Z

Tests passed during RECORDING mode:
TestAccSpannerDatabase_postgres[view]
TestAccSpannerDatabase_basic[view]

Tests failed during RECORDING mode:
TestAccContainerCluster_withAddons[view]
TestAccContainerCluster_withConfidentialNodes[view]

Please fix these to complete your PR
View the build log or the debug log for each test

…tention_period

modular-magician · 2022-06-27T18:36:05Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 416 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 7 files changed, 416 insertions(+), 32 deletions(-))
TF Validator: Diff ( 3 files changed, 62 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+))

SarahFrench · 2022-06-27T18:53:46Z

Hi @c2thorn, thanks for your review. After I learned about the ability to add post_create blocks I changed approach for this PR - covered here in this comment - which goes against the precedent set by #5799 but I agree results in better UX. I believe I've updated the necessary tests & documentation to describe this and no longer warn about needing to apply the config 2 times.

Also, re this from your last comment:

If they wanted to resume setting it via ddl, they would just need to remove the version_retention_period field right?

I added a new acceptance test in commit e302e6d that documents the expected behaviour of how the two fields interact - it's possible to swap back and forth between the two without any major downsides (other than out-of-date SQL in ddl that doesn't reflect the current state of the DB).

modular-magician · 2022-06-27T19:21:20Z

Tests analytics

Total tests: 2055
Passed tests 1825
Skipped tests: 226
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons|TestAccSpannerDatabase_versionRetentionPeriod

modular-magician · 2022-06-27T19:46:57Z

Tests passed during RECORDING mode:
TestAccSpannerDatabase_versionRetentionPeriod[view]
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccContainerCluster_withAddons[view]
TestAccContainerCluster_withConfidentialNodes[view]

Please fix these to complete your PR
View the build log or the debug log for each test

c2thorn · 2022-06-29T16:43:42Z

mmv1/third_party/terraform/tests/resource_spanner_database_test.go.erb

+				// - changes the value (from 2h to 8h)
+				// - is unstable; non-empty plan afterwards due to conflict
+				Config:             testAccSpannerDatabase_versionRetentionPeriodUpdate3(instanceName, databaseName),
+				ExpectNonEmptyPlan: true, // is unstable


Noting expected behavior, for posterity

c2thorn

Thanks for the improvements to ddl as well. This LGTM

modular-magician requested a review from c2thorn June 16, 2022 19:18

SarahFrench added 10 commits June 17, 2022 20:33

Add version_retention_period attribute to google_spanner_database res…

bc82444

…ource

Improve version_retention_period validation - check is within bounds

88f0b85

Fix bug when ddl is unset at create step, fix whitespace

221bf29

Add support for PostgreSQL-enabled databases

16b6925

Add DEBUG log about different creation behaviour for Postgres

b195bbf

Add unit test for validation function, fix regex

7c2a267

Regex previously didn't allow time periods of less than a day, but times of >1hour are valid in the API

Update existing Spanner database acceptance tests

f088370

Rearrange code for easier reading

3ed0682

Address make lint output

e218037

Add new field to google_spanner_database example file

17266d8

SarahFrench force-pushed the spanner-add-retention-period branch from afbeaf3 to 17266d8 Compare June 17, 2022 19:34

SarahFrench marked this pull request as ready for review June 17, 2022 19:45

Refactor to get default value from the API

bd87505

c2thorn requested changes Jun 21, 2022

View reviewed changes

Apply suggestions from code review

bdb8cd3

Co-authored-by: Cameron Thornton <[email protected]>

Move creation-time DDL to post-create code

3b78b94

Instead of DB dialect-specific logic, move all setting of DDL to a post-create, using updateDdl endpoint. Remove notes in documentation mentioning re-applying Terraform

Add acceptance tests defining relationship between ddl and version_re…

e302e6d

…tention_period

c2thorn reviewed Jun 29, 2022

View reviewed changes

c2thorn approved these changes Jun 29, 2022

View reviewed changes

c2thorn merged commit b6aff74 into GoogleCloudPlatform:main Jun 29, 2022

melinath mentioned this pull request Jun 30, 2022

Add support to allow create CMEK Redis instance in terraform #6197

Merged

5 tasks

SarahFrench deleted the spanner-add-retention-period branch June 30, 2022 18:55

knechtionscoding mentioned this pull request Jul 30, 2022

Spanner Database Resource should support versionRetentionPeriod and earliestVersionTime GoogleCloudPlatform/k8s-config-connector#544

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add version retention period to Spanner database resource #6141

Add version retention period to Spanner database resource #6141

SarahFrench commented Jun 16, 2022 •

edited

Loading

google-cla bot commented Jun 16, 2022

modular-magician commented Jun 16, 2022

modular-magician commented Jun 16, 2022

modular-magician commented Jun 16, 2022

modular-magician commented Jun 16, 2022

modular-magician commented Jun 16, 2022

modular-magician commented Jun 16, 2022

modular-magician commented Jun 17, 2022

modular-magician commented Jun 17, 2022

modular-magician commented Jun 17, 2022

SarahFrench commented Jun 17, 2022

modular-magician commented Jun 17, 2022

modular-magician commented Jun 17, 2022

modular-magician commented Jun 17, 2022

modular-magician commented Jun 20, 2022

modular-magician commented Jun 20, 2022

modular-magician commented Jun 20, 2022

c2thorn left a comment

c2thorn Jun 21, 2022

c2thorn Jun 21, 2022

SarahFrench Jun 27, 2022

c2thorn commented Jun 21, 2022

modular-magician commented Jun 22, 2022

modular-magician commented Jun 22, 2022

modular-magician commented Jun 22, 2022

modular-magician commented Jun 27, 2022

modular-magician commented Jun 27, 2022

modular-magician commented Jun 27, 2022

modular-magician commented Jun 27, 2022

SarahFrench commented Jun 27, 2022

modular-magician commented Jun 27, 2022

modular-magician commented Jun 27, 2022

c2thorn Jun 29, 2022

c2thorn left a comment

Add version retention period to Spanner database resource #6141

Add version retention period to Spanner database resource #6141

Conversation

SarahFrench commented Jun 16, 2022 • edited Loading

Description

Approach

Postgres issues

Open questions

PR steps

google-cla bot commented Jun 16, 2022

modular-magician commented Jun 16, 2022

modular-magician commented Jun 16, 2022

modular-magician commented Jun 16, 2022

modular-magician commented Jun 16, 2022

Diff report:

modular-magician commented Jun 16, 2022

Tests analytics

Action taken

modular-magician commented Jun 16, 2022

modular-magician commented Jun 17, 2022

modular-magician commented Jun 17, 2022

modular-magician commented Jun 17, 2022

Diff report:

SarahFrench commented Jun 17, 2022

modular-magician commented Jun 17, 2022

Diff report:

modular-magician commented Jun 17, 2022

Tests analytics

Action taken

modular-magician commented Jun 17, 2022

modular-magician commented Jun 20, 2022

Diff report:

modular-magician commented Jun 20, 2022

Tests analytics

Action taken

modular-magician commented Jun 20, 2022

c2thorn left a comment

Choose a reason for hiding this comment

c2thorn Jun 21, 2022

Choose a reason for hiding this comment

c2thorn Jun 21, 2022

Choose a reason for hiding this comment

SarahFrench Jun 27, 2022

Choose a reason for hiding this comment

c2thorn commented Jun 21, 2022

modular-magician commented Jun 22, 2022

Diff report:

modular-magician commented Jun 22, 2022

Tests analytics

Action taken

modular-magician commented Jun 22, 2022

modular-magician commented Jun 27, 2022

Diff report:

modular-magician commented Jun 27, 2022

Tests analytics

Action taken

modular-magician commented Jun 27, 2022

modular-magician commented Jun 27, 2022

Diff report:

SarahFrench commented Jun 27, 2022

modular-magician commented Jun 27, 2022

Tests analytics

Action taken

modular-magician commented Jun 27, 2022

c2thorn Jun 29, 2022

Choose a reason for hiding this comment

c2thorn left a comment

Choose a reason for hiding this comment

SarahFrench commented Jun 16, 2022 •

edited

Loading