Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sql database add deletion policy #6821

Merged

Conversation

tpryan
Copy link
Contributor

@tpryan tpryan commented Nov 12, 2022

This change adds the deletion_policy = abandon feature to google_sql_database. When enabled, terraform will skip this resource on destroy presumably because the author is getting rid of the instance the database resides in. This matches the intent and behavior of deletion_policy on google_sql_user

fixes hashicorp/terraform-provider-google#12968

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

sql: added field `deletion_policy` to resource `google_sql_database` 

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 102 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 4 files changed, 102 insertions(+), 3 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 118 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2249
Passed tests 2006
Skipped tests: 241
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccSQLDatabase_sqlDatabaseDeletionPolicyExample

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccSQLDatabase_sqlDatabaseDeletionPolicyExample[Debug log]

All tests passed
View the build log or the debug log for each test

mmv1/products/sql/terraform.yaml Outdated Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 99 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 99 insertions(+), 3 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 118 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2279
Passed tests 2033
Skipped tests: 244
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccLoggingBucketConfigProject_cmekSettings|TestAccFirebaserulesRelease_BasicRelease

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 104 insertions(+))
Terraform Beta: Diff ( 3 files changed, 104 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 118 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2281
Passed tests 2035
Skipped tests: 244
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccContainerNodePool_withNodeConfig|TestAccLoggingBucketConfigProject_cmekSettings

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccContainerNodePool_withNodeConfig[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

All tests passed
View the build log or the debug log for each test

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion on this topic I'm okay with allowing it for this resource in particular. Normally we wouldn't support ABANDON behavior in Terraform resources, but given that this particular resource has quirks due to blending of control-plane and data-plane operations during deletion and that sql_user has this behavior already due to a similar issues, it makes sense in this case.

See linked bugs for explanation of the issues with deleting DBs and users

@slevenick slevenick merged commit 59ea24b into GoogleCloudPlatform:main Nov 22, 2022
googlerjk pushed a commit to googlerjk/magic-modules that referenced this pull request Nov 25, 2022
* feat: adding deletion_policy=abandon to google_sql_database resource

* feat: honing in on correct behavior of google_sql_database

* feat: got tests to pass

* fix: simplified adding deletion_policy to google_sql_database

* chore: switch deletion_policy to virtual field
kimihrr pushed a commit to kimihrr/kimiah-magic-modules that referenced this pull request Dec 6, 2022
* feat: adding deletion_policy=abandon to google_sql_database resource

* feat: honing in on correct behavior of google_sql_database

* feat: got tests to pass

* fix: simplified adding deletion_policy to google_sql_database

* chore: switch deletion_policy to virtual field
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Dec 6, 2022
* feat: adding deletion_policy=abandon to google_sql_database resource

* feat: honing in on correct behavior of google_sql_database

* feat: got tests to pass

* fix: simplified adding deletion_policy to google_sql_database

* chore: switch deletion_policy to virtual field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent destroy behavior with google_sql_database
3 participants