-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sql database add deletion policy #6821
Sql database add deletion policy #6821
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 102 insertions(+), 3 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccSQLDatabase_sqlDatabaseDeletionPolicyExample |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 99 insertions(+), 3 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccLoggingBucketConfigProject_cmekSettings|TestAccFirebaserulesRelease_BasicRelease |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 104 insertions(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccContainerNodePool_withNodeConfig|TestAccLoggingBucketConfigProject_cmekSettings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussion on this topic I'm okay with allowing it for this resource in particular. Normally we wouldn't support ABANDON behavior in Terraform resources, but given that this particular resource has quirks due to blending of control-plane and data-plane operations during deletion and that sql_user has this behavior already due to a similar issues, it makes sense in this case.
See linked bugs for explanation of the issues with deleting DBs and users
* feat: adding deletion_policy=abandon to google_sql_database resource * feat: honing in on correct behavior of google_sql_database * feat: got tests to pass * fix: simplified adding deletion_policy to google_sql_database * chore: switch deletion_policy to virtual field
* feat: adding deletion_policy=abandon to google_sql_database resource * feat: honing in on correct behavior of google_sql_database * feat: got tests to pass * fix: simplified adding deletion_policy to google_sql_database * chore: switch deletion_policy to virtual field
* feat: adding deletion_policy=abandon to google_sql_database resource * feat: honing in on correct behavior of google_sql_database * feat: got tests to pass * fix: simplified adding deletion_policy to google_sql_database * chore: switch deletion_policy to virtual field
This change adds the deletion_policy = abandon feature to google_sql_database. When enabled, terraform will skip this resource on destroy presumably because the author is getting rid of the instance the database resides in. This matches the intent and behavior of deletion_policy on google_sql_user
fixes hashicorp/terraform-provider-google#12968
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)