Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sql database add deletion policy #324

Conversation

modular-magician
Copy link
Collaborator

This change adds the deletion_policy = abandon feature to google_sql_database. When enabled, terraform will skip this resource on destroy presumably because the author is getting rid of the instance the database resides in. This matches the intent and behavior of deletion_policy on google_sql_user

fixes hashicorp/terraform-provider-google#12968

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

sql: added field `deletion_policy` to resource `google_sql_database` 

Derived from GoogleCloudPlatform/magic-modules#6821

* feat: adding deletion_policy=abandon to google_sql_database resource

* feat: honing in on correct behavior of google_sql_database

* feat: got tests to pass

* fix: simplified adding deletion_policy to google_sql_database

* chore: switch deletion_policy to virtual field

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit e3ccc46 into terraform-google-modules:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent destroy behavior with google_sql_database
1 participant