Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vertexai): Add ignore_read: true to featureNormType because API doesn't return it #8288

Merged

Conversation

shotarok
Copy link
Contributor

@shotarok shotarok commented Jul 7, 2023

hashicorp/terraform-provider-google#12818

Add ignore_read: true to featureNormType because API doesn't return it. I put a sample response from https://cloud.google.com/vertex-ai/docs/reference/rest/v1/projects.locations.indexes/get.

Details
$ curl -X GET \
  -H "Authorization: Bearer $(gcloud auth application-default print-access-token)" \
  -H "Content-Type: application/json; charset=utf-8" \
  https://us-west1-aiplatform.googleapis.com/v1/projects/xxxxx/locations/us-west1/indexes/yyyyyy
{
  "name": "projects/xxxxx/locations/us-west1/indexes/yyyyyy",
  "displayName": "image",
  "description": "index for image embeddings",
  "metadataSchemaUri": "gs://google-cloud-aiplatform/schema/matchingengine/metadata/nearest_neighbor_search_1.0.0.yaml",
  "metadata": {
    "config": {
      "dimensions": 512,
      "approximateNeighborsCount": 150,
      "distanceMeasureType": "DOT_PRODUCT_DISTANCE",
      "algorithmConfig": {
        "treeAhConfig": {
          "leafNodeEmbeddingCount": "1000",
          "leafNodesToSearchPercent": 10
        }
      },
      "shardSize": "SHARD_SIZE_MEDIUM"
    }
  },
  "deployedIndexes": [
    {
      "indexEndpoint": "projects/xxxxx/locations/us-west1/indexEndpoints/zzzzzzz",
      "deployedIndexId": "all_items_index"
    }
  ],
  "etag": "AMEw9yMNTVf04pTQQ8AgKhgTuf3EgU0E6kMVg6xXd5SlGegGiQIIhh0Tss2Ko5__bUI=",
  "createTime": "2023-05-24T05:13:10.102697Z",
  "updateTime": "2023-07-06T23:44:31.005485Z",
  "indexStats": {
    "vectorsCount": "59914820",
    "shardsCount": 7
  },
  "indexUpdateMethod": "STREAM_UPDATE"
}

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

vertexai: fixed `feature_norm_type` in `google_vertex_ai_index` to avoid it from appearing repeatedly in terraform plan

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @ScottSuarez, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jul 7, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2831
Passed tests 2533
Skipped tests: 295
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccSpannerInstanceIamPolicy|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccSpannerInstanceIamPolicy[Debug log]

Tests failed during RECORDING mode:
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the field is absent in the response.. Thanks for the work!

@ScottSuarez ScottSuarez merged commit 2416bca into GoogleCloudPlatform:main Jul 10, 2023
baskaran-md pushed a commit to baskaran-md/magic-modules that referenced this pull request Jul 10, 2023
Khaledmohamedrefaat pushed a commit to Khaledmohamedrefaat/magic-modules that referenced this pull request Jul 13, 2023
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
wj-chen pushed a commit to wj-chen/magic-modules that referenced this pull request Aug 1, 2023
@shotarok shotarok deleted the update-feature-norm-type-field branch August 4, 2023 22:04
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants