-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to test feature branches in TeamCity #8388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was deleted because it was replaced by mmv1/third_party/terraform/.teamcity/components/generated/settings.erb
, when I made this file be generated
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 11 files changed, 90 insertions(+), 31 deletions(-)) |
427fc5d
to
979a7a8
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 11 files changed, 97 insertions(+), 38 deletions(-)) |
This is because Google provider has no public TeamCity resources
…ment` parameter in TeamCity
979a7a8
to
dc4b033
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 10 files changed, 86 insertions(+), 35 deletions(-)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 10 files changed, 93 insertions(+), 36 deletions(-)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 10 files changed, 93 insertions(+), 36 deletions(-)) |
Thanks for making the change! |
…#8388) * Add comments, link to TeamCity Kotlin DSL docs * Change default value of environment from "public" to "default" This is because Google provider has no public TeamCity resources * Enable different default cron values for `ga`/`beta` downstreams * Enable non-default cron values to be used, based on value of `environment` parameter in TeamCity * Add ability to make VCS root and nightly trigger use non-main branch * Update tests to reflect how entrypoint func requires `branch` parameter now * Update `MAJOR_RELEASE_TESTING` value, and update code to handle unsupported chars * Update `uniqueID` method to uppercase the environment value
…#8388) * Add comments, link to TeamCity Kotlin DSL docs * Change default value of environment from "public" to "default" This is because Google provider has no public TeamCity resources * Enable different default cron values for `ga`/`beta` downstreams * Enable non-default cron values to be used, based on value of `environment` parameter in TeamCity * Add ability to make VCS root and nightly trigger use non-main branch * Update tests to reflect how entrypoint func requires `branch` parameter now * Update `MAJOR_RELEASE_TESTING` value, and update code to handle unsupported chars * Update `uniqueID` method to uppercase the environment value
…#8388) * Add comments, link to TeamCity Kotlin DSL docs * Change default value of environment from "public" to "default" This is because Google provider has no public TeamCity resources * Enable different default cron values for `ga`/`beta` downstreams * Enable non-default cron values to be used, based on value of `environment` parameter in TeamCity * Add ability to make VCS root and nightly trigger use non-main branch * Update tests to reflect how entrypoint func requires `branch` parameter now * Update `MAJOR_RELEASE_TESTING` value, and update code to handle unsupported chars * Update `uniqueID` method to uppercase the environment value
…#8388) * Add comments, link to TeamCity Kotlin DSL docs * Change default value of environment from "public" to "default" This is because Google provider has no public TeamCity resources * Enable different default cron values for `ga`/`beta` downstreams * Enable non-default cron values to be used, based on value of `environment` parameter in TeamCity * Add ability to make VCS root and nightly trigger use non-main branch * Update tests to reflect how entrypoint func requires `branch` parameter now * Update `MAJOR_RELEASE_TESTING` value, and update code to handle unsupported chars * Update `uniqueID` method to uppercase the environment value
Description
This PR
environment
to"default"
, away from"public"
, as we have no concept of public TeamCity projects for the Google providerThese are the requirements that this PR fulfils:
main
branch will have nightly tests run all other days of the week (Mon-Wed, Fri-Sun)main
branch will have nightly tests run all other days of the week (Mon-Thurs, Sat-Sun)Changes in this PR
This PR makes the settings.kt file generated, and depending on whether
version
isga
orbeta
a different value is set fordefaultDaysOfWeek
, see here. These are the days that themain
branch will be tested.To determine which days the feature branch tests run, the
testConfiguration
class in this file is updated to check theenvironment
context parameter and return either the default cron values (formain
) or values specific to the feature branch.How feature branch testing projects are set up in TeamCity
To set up a TeamCity project that tests feature branches one would need to:
environment
andbranch
like in the screenshot below (note, other context parameters are needed to supply things like ENVs for configuring the provider during acceptance tests).Release Note Template for Downstream PRs (will be copied)