Add ability to test feature branches in TeamCity #15246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add comments, link to TeamCity Kotlin DSL docs * Change default value of environment from "public" to "default" This is because Google provider has no public TeamCity resources * Enable different default cron values for `ga`/`beta` downstreams * Enable non-default cron values to be used, based on value of `environment` parameter in TeamCity * Add ability to make VCS root and nightly trigger use non-main branch * Update tests to reflect how entrypoint func requires `branch` parameter now * Update `MAJOR_RELEASE_TESTING` value, and update code to handle unsupported chars * Update `uniqueID` method to uppercase the environment value Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
environmentto"default", away from"public", as we have no concept of public TeamCity projects for the Google providerThese are the requirements that this PR fulfils:
mainbranch will have nightly tests run all other days of the week (Mon-Wed, Fri-Sun)mainbranch will have nightly tests run all other days of the week (Mon-Thurs, Sat-Sun)Changes in this PR
This PR makes the settings.kt file generated, and depending on whether
versionisgaorbetaa different value is set fordefaultDaysOfWeek, see here. These are the days that themainbranch will be tested.To determine which days the feature branch tests run, the
testConfigurationclass in this file is updated to check theenvironmentcontext parameter and return either the default cron values (formain) or values specific to the feature branch.How feature branch testing projects are set up in TeamCity
To set up a TeamCity project that tests feature branches one would need to:
environmentandbranchlike in the screenshot below (note, other context parameters are needed to supply things like ENVs for configuring the provider during acceptance tests).Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#8388