Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Terraform support for game services #8669

Merged
merged 3 commits into from
Aug 18, 2023

Conversation

hao-nan-li
Copy link
Contributor

Remove Terraform support for game services.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

gameservices: Remove Terraform support for `gameservices`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 25 files changed, 2 insertions(+), 4229 deletions(-))
Terraform Beta: Diff ( 25 files changed, 2 insertions(+), 4229 deletions(-))
TF Conversion: Diff ( 7 files changed, 754 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1
Passed tests 1
Skipped tests: 0
Affected tests: 0

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR}}$
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Resource google_game_services_game_server_cluster was either removed or renamed - reference
  • Resource google_game_services_game_server_config was either removed or renamed - reference
  • Resource google_game_services_game_server_deployment_rollout was either removed or renamed - reference
  • Resource google_game_services_game_server_deployment was either removed or renamed - reference
  • Resource google_game_services_realm was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 25 files changed, 2 insertions(+), 4230 deletions(-))
Terraform Beta: Diff ( 25 files changed, 2 insertions(+), 4230 deletions(-))
TF Conversion: Diff ( 7 files changed, 754 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2946
Passed tests 2639
Skipped tests: 307
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@hao-nan-li hao-nan-li marked this pull request as ready for review August 17, 2023 17:06
@c2thorn
Copy link
Member

c2thorn commented Aug 17, 2023

google-conversion is failing... are we expecting it to here?

/go/pkg/mod/github.com/modular-magician/terraform-provider-google-beta@v1.20.1-0.20230816180001-e7f5f0defd12/google-beta/provider/provider.go:895:58: undefined: gameservices

I can't see the line in the generated diff

@c2thorn
Copy link
Member

c2thorn commented Aug 17, 2023

Is there an upgrade guide entry PR?

@hao-nan-li
Copy link
Contributor Author

hao-nan-li commented Aug 17, 2023

Is there an upgrade guide entry PR?

(#8693)

@hao-nan-li
Copy link
Contributor Author

hao-nan-li commented Aug 17, 2023

google-conversion is failing... are we expecting it to here?

/go/pkg/mod/github.com/modular-magician/terraform-provider-google-beta@v1.20.1-0.20230816180001-e7f5f0defd12/google-beta/provider/provider.go:895:58: undefined: gameservices

I can't see the line in the generated diff

I need to double-check a bit, maybe there's something I missed during the removal. Thanks for highlighting the error.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Resource google_game_services_game_server_cluster was either removed or renamed - reference
  • Resource google_game_services_game_server_config was either removed or renamed - reference
  • Resource google_game_services_game_server_deployment_rollout was either removed or renamed - reference
  • Resource google_game_services_game_server_deployment was either removed or renamed - reference
  • Resource google_game_services_realm was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 26 files changed, 7 insertions(+), 4230 deletions(-))
Terraform Beta: Diff ( 25 files changed, 2 insertions(+), 4230 deletions(-))
TF Conversion: Diff ( 7 files changed, 754 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2946
Passed tests 2639
Skipped tests: 307
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@c2thorn c2thorn added the override-breaking-change Allows a potential breaking change to be merged label Aug 18, 2023
Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the label, don't remember if we need it for this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
override-breaking-change Allows a potential breaking change to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants