-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove firebase_project_location #8783
Remove firebase_project_location #8783
Conversation
Hello! I am a robot. It looks like you are a: @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 1 insertion(+), 30 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're seeing this error in the build:
google-beta/services/firebase/resource_firebase_project_location.go:68:2: config declared but not used
I think it is because the config
var used by the create function normally is not being used anymore. Do you know if there is precedence for the pattern you're using here?
I don't find a precedent. I'm trying to follow https://developer.hashicorp.com/terraform/plugin/sdkv2/best-practices/deprecations#provider-data-source-or-resource-removal, which says to
Since this resource doesn't have any attributes, I don't think anyone would be reading them, but the Create function should be blocked. Is there a better way to do that than custom_create? |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change Detection FailedThe breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer. Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 1 insertion(+), 30 deletions(-)) |
6f6b862
to
495f23b
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 1 insertion(+), 30 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocJobIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c2thorn would you mind weighing in on this? I wasn't able to find any precedent for deprecating resources, but this approach makes sense to me and seems to match the guidance from HashiCorp.
495f23b
to
0181825
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 1 insertion(+), 30 deletions(-)) |
Tests analyticsTotal tests:
|
Friendly ping @c2thorn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For other removed resources (like google_project_services
and game services) we just completely delete the related code and do not leave stubbed resources. It would be nice for users to get a specific message stating that the resource is no longer available, but as of now we prefer to just completely remove.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 115 deletions(-)) |
Tests analyticsTotal tests:
|
We should add the actual deprecation message and upgrade guide note in the |
Updated PR description. |
I've added hashicorp/terraform-provider-google#15763 for our tracking efforts. If there is a buganizer number, do you mind adding the b/##### to the issue? @rainshen49 |
85bf78e
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0
Throw an error when users try to use the
google_firebase_project_location
resource in the 5.0.0 version.closes hashicorp/terraform-provider-google#15763
If this PR is for Terraform, I acknowledge that I have:
Release Note Template for Downstream PRs (will be copied)