Add ssl_mode option to google_sql_database_instance.

[feng-zhe]

This PR adds support for the new field ssl_mode to google_sql_database_instance. This new field is only available for google.golang.org/api v0.148.0 or after. Acctests are added for each database types and they all passed.

Release Note Template for Downstream PRs (will be copied)

sql: added `ssl_mode` field to `google_sql_database_instance` resource

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[roaks3]

Some nits, but LGTM. Main thing is if we can reduce the tests a bit.

[roaks3]

Running tests now, but code LGTM

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change Detection Failed

The breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 328 insertions(+), 239 deletions(-))
Terraform Beta: Diff ( 5 files changed, 328 insertions(+), 239 deletions(-))

[roaks3]

Build error is:

Step #22 - "gcb-tpg-vcr-test": go: updates to go.mod needed; to update it:
Step #22 - "gcb-tpg-vcr-test": 	go mod tidy

I suspect the library bump needs to be fixed (see yaqs/8444818848342867968#a1n2)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change Detection Failed

The breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 361 insertions(+), 271 deletions(-))
Terraform Beta: Diff ( 5 files changed, 361 insertions(+), 271 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 123 insertions(+), 36 deletions(-))
Terraform Beta: Diff ( 5 files changed, 123 insertions(+), 36 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sql_database_instance (94 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  settings {
    ip_configuration {
      ssl_mode = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 3171
Passed tests 2851
Skipped tests: 319
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[feng-zhe]

It is unclear why the above test terraform-google-conversion-build-and-unit-tests failed. The error is

../../../../go/pkg/mod/github.com/modular-magician/terraform-provider-google-beta@v1.20.1-0.20231024211950-df57ab7a5264/google-beta/services/sql/resource_sql_database_instance.go:441:147: syntax error: unexpected newline in composite literal; possibly missing comma or }

But that should have been fixed by 5b96b40. And I manually generated the provider locally and there is no error.