feat: Add ssl_mode option to google_sql_database_instance. #16394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#9367) * feat: Add ssl_mode option to google_sql_database_instance. * Put the github.com/google/go-cmp v0.5.9 back to the go.sum. Deleted it in previous commit by mistake. * Update go.mod.erb and go.sum since the commit 6aa307c reverts the commit f3db9dd. [upstream:3f433e1c3724481aa3e1649520cab5de33ee6157] Signed-off-by: Modular Magician <[email protected]>
roaks3
added a commit
that referenced
this pull request
Nov 3, 2023
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new field ssl_mode to google_sql_database_instance. This new field is only available for google.golang.org/api v0.148.0 or after. Acctests are added for each database types and they all passed.
This is almost the same as the previous PR but this one adds
Computed: trueto thessl_modefield so that its old value will be used in requests.Tested the following tests which were broken by the previous PR but they are passing in this PR:
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9367