-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling management of default Dialogflow resources without terraform import: name
field editable
#9359
Conversation
…Default Negative Intent, without terraform import (v2!)
Hello! I am a robot. It looks like you are a: @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Assigning to the previous reviewer since there is on-going context. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 8 files changed, 633 insertions(+), 54 deletions(-)) |
…the Default Negative Intent :(
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 8 files changed, 629 insertions(+), 27 deletions(-)) |
@@ -62,9 +73,11 @@ parameters: | |||
properties: | |||
- !ruby/object:Api::Type::String | |||
name: 'name' | |||
output: true | |||
default_from_api: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW I misunderstood the question regarding reading from the API so I'm not sure this design will work out - sorry for the confusion! I'll take a look over the designs & offer some thoughts since we chatted about this earlier but ultimately Sarah is the reviewer here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some notes on the other PR.
Tests analyticsTotal tests: Action takenFound 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDialogflowCXIntent_dialogflowcxIntentDefaultNegativeIntentExample|TestAccDialogflowCXIntent_dialogflowcxIntentDefaultWelcomeIntentExample|TestAccDialogflowCXFlow_dialogflowcxFlowBasicExample|TestAccDialogflowCXFlow_dialogflowcxFlowDefaultStartFlowExample|TestAccDialogflowCXFlow_defaultStartFlow|TestAccDialogflowCXIntent_defaultIntents|TestAccDialogflowCXIntent_dialogflowcxIntentFullExample|TestAccDialogflowCXIntent_update|TestAccDialogflowCXTestCase_update|TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample|TestAccDialogflowCXFlow_update|TestAccDialogflowCXFlow_dialogflowcxFlowFullExample|TestAccSpannerInstanceIamPolicy|TestAccSpannerDatabaseIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 8 files changed, 651 insertions(+), 25 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccDialogflowCXFlow_dialogflowcxFlowBasicExample|TestAccDialogflowCXIntent_defaultIntents|TestAccSpannerInstanceIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 8 files changed, 651 insertions(+), 25 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDialogflowCXIntent_defaultIntents |
Rerun these tests in REPLAYING mode to catch issues
|
name
field editable
Of the two approaches I prefer using new boolean fields over the Because of that I'll resume reviewing #9336 and this PR could be closed when the other PR is merged. |
|
Fixes hashicorp/terraform-provider-google#16308, read that bug for more context 😅
An alternative version of #9336 because designing a good API is hard and I want someone else to make that decision 😅.
Release Note Template for Downstream PRs (will be copied)