-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't easily update DialogflowCX "Default start flow" or "Default welcome intent" #16308
Can't easily update DialogflowCX "Default start flow" or "Default welcome intent" #16308
Comments
sounds like we'd be going for a "acquire at create time" flow here. |
…Default Negative Intent, without terraform import Fixes hashicorp/terraform-provider-google#16308
100% with this, I am needing to modify the transition routes (and route groups), and while it is annoying to have to split the work, it's even more annoying that destroy commands don't work. Need to create a new |
… import: `is_default_x` fields (#9336) * Enabling management of Default Start Flow + Default Welcome Intent + Default Negative Intent, without terraform import Fixes hashicorp/terraform-provider-google#16308 * Basic tests for default flow + intents * Tests asserting resource IDs * Making Flow + Intent import respect is_default_X; fixing description on examples * Bah, making isFallback output-only might break users that'd imported the Default Negative Intent :( * Update mmv1/templates/terraform/pre_create/dialogflowcx_set_location_skip_default_obj.go.erb Co-authored-by: Sarah French <[email protected]> * Adding callout notes about multiple is_default_x resources * More words around the pre-create + pre-delete code * Adding more tests around Default Start Flow * Adding more tests around Default Welcome Intent and Default Negative Intent --------- Co-authored-by: Sarah French <[email protected]>
… import: `is_default_x` fields (#9336) * Enabling management of Default Start Flow + Default Welcome Intent + Default Negative Intent, without terraform import Fixes hashicorp/terraform-provider-google#16308 * Basic tests for default flow + intents * Tests asserting resource IDs * Making Flow + Intent import respect is_default_X; fixing description on examples * Bah, making isFallback output-only might break users that'd imported the Default Negative Intent :( * Update mmv1/templates/terraform/pre_create/dialogflowcx_set_location_skip_default_obj.go.erb Co-authored-by: Sarah French <[email protected]> * Adding callout notes about multiple is_default_x resources * More words around the pre-create + pre-delete code * Adding more tests around Default Start Flow * Adding more tests around Default Welcome Intent and Default Negative Intent --------- Co-authored-by: Sarah French <[email protected]> [upstream:58d0735cfa46a3668a0c5af3181ce6443ab22d91] Signed-off-by: Modular Magician <[email protected]>
… import: `is_default_x` fields (#9336) (#589) * Enabling management of Default Start Flow + Default Welcome Intent + Default Negative Intent, without terraform import Fixes hashicorp/terraform-provider-google#16308 * Basic tests for default flow + intents * Tests asserting resource IDs * Making Flow + Intent import respect is_default_X; fixing description on examples * Bah, making isFallback output-only might break users that'd imported the Default Negative Intent :( * Update mmv1/templates/terraform/pre_create/dialogflowcx_set_location_skip_default_obj.go.erb * Adding callout notes about multiple is_default_x resources * More words around the pre-create + pre-delete code * Adding more tests around Default Start Flow * Adding more tests around Default Welcome Intent and Default Negative Intent --------- [upstream:58d0735cfa46a3668a0c5af3181ce6443ab22d91] Signed-off-by: Modular Magician <[email protected]>
… import: `is_default_x` fields (#9336) * Enabling management of Default Start Flow + Default Welcome Intent + Default Negative Intent, without terraform import Fixes hashicorp/terraform-provider-google#16308 * Basic tests for default flow + intents * Tests asserting resource IDs * Making Flow + Intent import respect is_default_X; fixing description on examples * Bah, making isFallback output-only might break users that'd imported the Default Negative Intent :( * Update mmv1/templates/terraform/pre_create/dialogflowcx_set_location_skip_default_obj.go.erb Co-authored-by: Sarah French <[email protected]> * Adding callout notes about multiple is_default_x resources * More words around the pre-create + pre-delete code * Adding more tests around Default Start Flow * Adding more tests around Default Welcome Intent and Default Negative Intent --------- Co-authored-by: Sarah French <[email protected]> [upstream:58d0735cfa46a3668a0c5af3181ce6443ab22d91] Signed-off-by: Modular Magician <[email protected]>
… import: `is_default_x` fields (hashicorp#9336) * Enabling management of Default Start Flow + Default Welcome Intent + Default Negative Intent, without terraform import Fixes hashicorp#16308 * Basic tests for default flow + intents * Tests asserting resource IDs * Making Flow + Intent import respect is_default_X; fixing description on examples * Bah, making isFallback output-only might break users that'd imported the Default Negative Intent :( * Update mmv1/templates/terraform/pre_create/dialogflowcx_set_location_skip_default_obj.go.erb Co-authored-by: Sarah French <[email protected]> * Adding callout notes about multiple is_default_x resources * More words around the pre-create + pre-delete code * Adding more tests around Default Start Flow * Adding more tests around Default Welcome Intent and Default Negative Intent --------- Co-authored-by: Sarah French <[email protected]> [upstream:58d0735cfa46a3668a0c5af3181ce6443ab22d91] Signed-off-by: Modular Magician <[email protected]>
… import: `is_default_x` fields (#9336) (#6600) * Enabling management of Default Start Flow + Default Welcome Intent + Default Negative Intent, without terraform import Fixes hashicorp/terraform-provider-google#16308 * Basic tests for default flow + intents * Tests asserting resource IDs * Making Flow + Intent import respect is_default_X; fixing description on examples * Bah, making isFallback output-only might break users that'd imported the Default Negative Intent :( * Update mmv1/templates/terraform/pre_create/dialogflowcx_set_location_skip_default_obj.go.erb * Adding callout notes about multiple is_default_x resources * More words around the pre-create + pre-delete code * Adding more tests around Default Start Flow * Adding more tests around Default Welcome Intent and Default Negative Intent --------- [upstream:58d0735cfa46a3668a0c5af3181ce6443ab22d91] Signed-off-by: Modular Magician <[email protected]>
… import: `is_default_x` fields (#9336) (#16441) * Enabling management of Default Start Flow + Default Welcome Intent + Default Negative Intent, without terraform import Fixes #16308 * Basic tests for default flow + intents * Tests asserting resource IDs * Making Flow + Intent import respect is_default_X; fixing description on examples * Bah, making isFallback output-only might break users that'd imported the Default Negative Intent :( * Update mmv1/templates/terraform/pre_create/dialogflowcx_set_location_skip_default_obj.go.erb * Adding callout notes about multiple is_default_x resources * More words around the pre-create + pre-delete code * Adding more tests around Default Start Flow * Adding more tests around Default Welcome Intent and Default Negative Intent --------- [upstream:58d0735cfa46a3668a0c5af3181ce6443ab22d91] Signed-off-by: Modular Magician <[email protected]>
… import: `is_default_x` fields (GoogleCloudPlatform#9336) * Enabling management of Default Start Flow + Default Welcome Intent + Default Negative Intent, without terraform import Fixes hashicorp/terraform-provider-google#16308 * Basic tests for default flow + intents * Tests asserting resource IDs * Making Flow + Intent import respect is_default_X; fixing description on examples * Bah, making isFallback output-only might break users that'd imported the Default Negative Intent :( * Update mmv1/templates/terraform/pre_create/dialogflowcx_set_location_skip_default_obj.go.erb Co-authored-by: Sarah French <[email protected]> * Adding callout notes about multiple is_default_x resources * More words around the pre-create + pre-delete code * Adding more tests around Default Start Flow * Adding more tests around Default Welcome Intent and Default Negative Intent --------- Co-authored-by: Sarah French <[email protected]>
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Description
When you create a Dialogflow CX Agent, it automatically creates a DF CX Flow for you; this is the
Agent.startFlow
; the API docs say "A start flow will be automatically created when the agent is created, and can only be deleted by deleting the agent". Other docs say it'll have "the following flow ID:00000000-0000-0000-0000-000000000000
" i.e. Agent.startFlow will always beprojects/<project-id>/locations/<location-id>/agents/<agent-id>/flows/00000000-0000-0000-0000-000000000000
You cannot easily manage this resource in terraform. You have to import it. You know what the
terraform import
command would look like. You can easily write theimport
block:UNFORTUNATELY, the
import
block is still pretty dumb; if you write that completely reasonable looking terraform, it errors withi.e. there's no one-
terraform apply
way of managing an Agent + the default start flow. You have to break it into two steps (step 1: apply the agent creation; step 2: import). That's annoying.Also, even if terraform improves the
import
block, you're not allowed to delete a default start flow; GCP gives you an error. That's annoying too if you want to remove resources or stop managing stuff.Same situation for the Default welcome intent, just swap out "intent" for "flow" above.
I wasn't able to find a feature request against terraform itself for improving the
import
block behavior.New or Affected Resource(s)
Potential Terraform Configuration (implemented in GoogleCloudPlatform/magic-modules#9336)
Make the
is_defult_X
fields immutable + not written to the REST API. If they'retrue
, prevent the resource from being created (http POST) or destroyed (http DELETE) and just set the ID to{parent}/flows/00000000-0000-0000-0000-000000000000
or{parent}/intents/00000000-0000-0000-0000-000000000000
.Potential Terraform Configuration (implemented in GoogleCloudPlatform/magic-modules#9359)
Make the
name
property settable, immutable, and default-from-API. If it's set by the user, PATCH instead of POST and prevent DELETEs.Potential Terraform Configuration (not implemented yet)
Make three new resources that are hyper-specialized copy-pastes of the existing
flow
+intent
resources. Don't let them POST or DELETE cloud resources.References
b/307909166
The text was updated successfully, but these errors were encountered: