Make notebooks wait for active state and enable stopping/starting ins…

[bcreddy-gcp]

…tances using the desired_state field

Release Note Template for Downstream PRs (will be copied)

made `google_notebooks_instance` wait for active state on creation and enable stopping/starting instances.

[bcreddy-gcp]

Similar to #9945. Fyi: @slevenick

[hao-nan-li]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 169 insertions(+))
Terraform Beta: Diff ( 4 files changed, 250 insertions(+))
TF Conversion: Diff ( 1 file changed, 20 insertions(+))
TF OiCS: Diff ( 4 files changed, 111 insertions(+))

[modular-magician]

Tests analytics

Total tests: 24
Passed tests: 11
Skipped tests: 0
Affected tests: 13

Click here to see the affected service packages

• notebooks

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNotebooksInstanceIamBindingGenerated|TestAccNotebooksInstanceIamMemberGenerated|TestAccNotebooksInstanceIamPolicyGenerated|TestAccNotebooksInstance_create_container|TestAccNotebooksInstance_create_gpu|TestAccNotebooksInstance_create_vm_image|TestAccNotebooksInstance_notebookInstanceBasicContainerExample|TestAccNotebooksInstance_notebookInstanceBasicExample|TestAccNotebooksInstance_notebookInstanceBasicGpuExample|TestAccNotebooksInstance_notebookInstanceBasicStoppedExample|TestAccNotebooksInstance_notebookInstanceFullExample|TestAccNotebooksInstance_state|TestAccNotebooksInstance_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNotebooksInstanceIamBindingGenerated[Debug log]
TestAccNotebooksInstanceIamMemberGenerated[Debug log]
TestAccNotebooksInstanceIamPolicyGenerated[Debug log]
TestAccNotebooksInstance_create_container[Debug log]
TestAccNotebooksInstance_create_gpu[Debug log]
TestAccNotebooksInstance_create_vm_image[Debug log]
TestAccNotebooksInstance_notebookInstanceBasicContainerExample[Debug log]
TestAccNotebooksInstance_notebookInstanceBasicExample[Debug log]
TestAccNotebooksInstance_notebookInstanceBasicGpuExample[Debug log]
TestAccNotebooksInstance_notebookInstanceBasicStoppedExample[Debug log]
TestAccNotebooksInstance_notebookInstanceFullExample[Debug log]
TestAccNotebooksInstance_state[Debug log]
TestAccNotebooksInstance_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[hao-nan-li]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 169 insertions(+))
Terraform Beta: Diff ( 4 files changed, 250 insertions(+))
TF Conversion: Diff ( 1 file changed, 20 insertions(+))
TF OiCS: Diff ( 4 files changed, 111 insertions(+))

[modular-magician]

Tests analytics

Total tests: 24
Passed tests: 24
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• notebooks

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

[hao-nan-li]

Could you add a release note? Thanks

[bcreddy-gcp]

Added the release note