Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make notebooks wait for active state and enable stopping/starting ins… #1950

Conversation

modular-magician
Copy link
Collaborator

…tances using the desired_state field

Release Note Template for Downstream PRs (will be copied)

made `google_notebooks_instance` wait for active state on creation and enable stopping/starting instances.

Derived from GoogleCloudPlatform/magic-modules#9971

…… (#9971)

* Make notebooks wait for active state and enable stopping/starting instances using the desired_state field

* ignore update_time

[upstream:18072d2b0665b0182e8bcd677fc1d0ca75693507]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner February 13, 2024 21:20
@modular-magician modular-magician requested review from ScottSuarez and removed request for a team February 13, 2024 21:20
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician merged commit 2618402 into GoogleCloudPlatform:main Feb 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant