Make recommendation service optional (#1332)

* support missing recommendation service * support in view cart * lint * improve comment
GoogleCloudPlatform · Dec 1, 2022 · dfc78b9 · dfc78b9
1 parent 919b088
commit dfc78b9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/frontend/handlers.go b/src/frontend/handlers.go
@@ -176,10 +176,10 @@ func (fe *frontendServer) productHandler(w http.ResponseWriter, r *http.Request)
 		return
 	}
 
+	// ignores the error retrieving recommendations since it is not critical
 	recommendations, err := fe.getRecommendations(r.Context(), sessionID(r), []string{id})
 	if err != nil {
-		renderHTTPError(log, r, w, errors.Wrap(err, "failed to get product recommendations"), http.StatusInternalServerError)
-		return
+		log.WithField("error", err).Warn("failed to get product recommendations")
 	}
 
 	product := struct {
@@ -256,10 +256,10 @@ func (fe *frontendServer) viewCartHandler(w http.ResponseWriter, r *http.Request
 		return
 	}
 
+	// ignores the error retrieving recommendations since it is not critical
 	recommendations, err := fe.getRecommendations(r.Context(), sessionID(r), cartIDs(cart))
 	if err != nil {
-		renderHTTPError(log, r, w, errors.Wrap(err, "failed to get product recommendations"), http.StatusInternalServerError)
-		return
+		log.WithField("error", err).Warn("failed to get product recommendations")
 	}
 
 	shippingCost, err := fe.getShippingQuote(r.Context(), cart, currentCurrency(r))

diff --git a/src/frontend/templates/cart.html b/src/frontend/templates/cart.html
@@ -225,7 +225,7 @@ <h3 class="payment-method-heading">Payment Method</h3>
 
     </main>
 
-    {{ if $.recommendations}}
+    {{ if $.recommendations }}
         {{ template "recommendations" $.recommendations }}
     {{ end }}