Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect metadata endpoint in GAE standard sample #616

Closed
ghost opened this issue May 10, 2018 · 3 comments
Closed

Incorrect metadata endpoint in GAE standard sample #616

ghost opened this issue May 10, 2018 · 3 comments
Assignees

Comments

@ghost
Copy link

ghost commented May 10, 2018

Issue found in the following file:
https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/master/appengine/metadata/standard/server.js#L25

According to the currently documented list of App Engine metadata server endpoints, the endpoint used in this sample (/computeMetadata/v1/instance/network-interfaces) is not available in the App Engine standard environment.

@michaelawyu michaelawyu self-assigned this May 10, 2018
@michaelawyu
Copy link
Contributor

I will update this sample to use project-id instead external-ip :)

@michaelawyu
Copy link
Contributor

@ericschmidtatwork PR sent: #617

I vaguely recall that this sample was updated to use project ID before...

@michaelawyu
Copy link
Contributor

PR merged: #624

Shabirmean pushed a commit that referenced this issue Feb 16, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant