Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update appengine/metadata/standard sample #624

Merged
merged 2 commits into from
May 23, 2018

Conversation

michaelawyu
Copy link
Contributor

@michaelawyu michaelawyu commented May 23, 2018

Previous PR closed.

Unknown_Project_ID is added back to make the tests work.

@michaelawyu michaelawyu requested a review from ace-n May 23, 2018 01:19
@codecov
Copy link

codecov bot commented May 23, 2018

Codecov Report

Merging #624 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #624   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5091a97...e82c4e0. Read the comment docs.

Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when tests pass (note the appengine-metadata build is failing).

@michaelawyu
Copy link
Contributor Author

Test passed. Merged.

@michaelawyu michaelawyu merged commit bce81f4 into master May 23, 2018
@jmdobry jmdobry deleted the michaelawyu-patch-appengine-metadata branch June 27, 2018 22:25
Shabirmean pushed a commit that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants