Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Upgrade composer sample to Node 8 #1320

Merged
merged 2 commits into from
May 29, 2019
Merged

fix: Upgrade composer sample to Node 8 #1320

merged 2 commits into from
May 29, 2019

Conversation

leahecole
Copy link
Contributor

add "await" to .json() calls so Promises are resolved, change 'event' to 'data'

@leahecole leahecole requested review from fhinkel and ace-n May 28, 2019 07:14
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 28, 2019
@leahecole leahecole changed the title Upgrade composer sample to Node 8 fix: Upgrade composer sample to Node 8 May 28, 2019
ace-n
ace-n approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass. (They're not running on CI for some reason; mind submitting a (separate) PR + CL to fix that? 🙂)

@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 29, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 29, 2019
@leahecole leahecole merged commit 694c383 into master May 29, 2019
@leahecole leahecole deleted the upgrade-composer-sample branch May 29, 2019 18:41
@ace-n ace-n mentioned this pull request Jun 5, 2019
Closed
This was referenced May 13, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request May 13, 2022
Open
This was referenced May 13, 2022
Open
Open
Open
@leejh3224 leejh3224 mentioned this pull request May 13, 2022
Open
This was referenced May 13, 2022
Open
Open
Open
@leejh3224 leejh3224 mentioned this pull request May 13, 2022
Open
@ninadhatkar ninadhatkar mentioned this pull request May 13, 2022
Open
@leejh3224 leejh3224 mentioned this pull request May 14, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 14, 2022
Open
@ninadhatkar ninadhatkar mentioned this pull request May 14, 2022
Open
This was referenced May 14, 2022
Open
Open
@ninadhatkar ninadhatkar mentioned this pull request May 14, 2022
Open
This was referenced May 14, 2022
Open
Open
Open
@ninadhatkar ninadhatkar mentioned this pull request May 14, 2022
Open
@leejh3224 leejh3224 mentioned this pull request May 14, 2022
Open
@ninadhatkar ninadhatkar mentioned this pull request May 14, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 14, 2022
Open
@leejh3224 leejh3224 mentioned this pull request May 14, 2022
Open
This was referenced Jun 20, 2023
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ace-n ace-n ace-n approved these changes

@fhinkel fhinkel Awaiting requested review from fhinkel

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leahecole @ace-n @googlebot @kokoro-team