Cloud Composer DAG trigger sample uses to-be-deprecated JS

[starmandeluxe]

The code sample for triggering a Cloud Composer DAG using a Cloud Function should be refactored to support nodejs8 since it is using nodejs6 which will be deprecated on April 22, 2020.

[fhinkel]

cc @ace-n

[ace-n]

cc @stew-r

[stew-r]

Is this sample actually used anywhere on the Cloud Functions docs?

Google Search doesn't show me any instances where it is being used. If we're not showing this sample in our docs, we can kill it.

[ace-n]

It's used on this page.

@tswast is this something we can upgrade to Node 8?

[tswast]

Yes, please do upgrade the Composer DAG trigger sample.

CC @leahecole

[stew-r]

Yes, from Cloud Functions perspective, we don't need a Node.js 6 sample for this.

…

On Mon, May 20, 2019 at 6:02 PM Ace Nassri ***@***.***> wrote: It's used on this page <https://cloud.google.com/composer/docs/how-to/using/triggering-with-gcf#testing_your_function> . @tswast <https://github.com/tswast> is this something we can upgrade to Node 8? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1260?email_source=notifications&email_token=AHYELQFVFABD62I3O2OKCQ3PWNC2HA5CNFSM4HKRSQK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV2ORLI#issuecomment-494201005>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHYELQHY7UY42GBNX5PMFNLPWNC2HANCNFSM4HKRSQKQ> .

-- Stewart Reichling | Product Manager, Serverless | [email protected] | 650.906.3381

[leahecole]

Ack. Definitely can do that upgrade v. soon - it's related to some work I'm doing with that sample.

[ace-n]

Updated linting rules to check for Node 8 here. Will work with @fhinkel to iterate on these - hopefully that'll wrap up by EOD today.

[leahecole]

Great - I'll hold off until that's merged. Thanks so much for this!

[leahecole]

Any updates on when this will be merged @ace-n ? Trying to decide if I should wait for the linter or if I should just go for it and do the changes without the linter.

[ace-n]

I'd go for it now. The linter changes should be merged + added to CI anyway by the time you're done, so if you merge master into your branch + check CI they'll show up there (likely as WARNINGs - so CI may still pass). 🙂

[leahecole]

Just as an FYI I submitted a CL to update the screenshot in the tutorial to also suggest using Node 8 - working with @ace-n to convert code appropriately

[ace-n]

This was updated in #1320 and #1321 (thanks @leahecole!) - marking as fixed.