Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add kokoro config for composer-storage-trigger #1321

Merged
merged 2 commits into from
May 29, 2019
Merged

fix: add kokoro config for composer-storage-trigger #1321

merged 2 commits into from
May 29, 2019

Conversation

leahecole
Copy link
Contributor

No description provided.

@leahecole leahecole requested a review from ace-n May 28, 2019 20:30
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 28, 2019
ace-n
ace-n approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make sure the (internal) CL is merged first + the test it adds passes. 👍

@leahecole
Copy link
Contributor Author

Test does pass locally so 🤞 that it would work in CI. Just did the edits to the internal CL

@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 29, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 29, 2019
@leahecole leahecole merged commit c00c94f into master May 29, 2019
@ace-n ace-n mentioned this pull request Jun 5, 2019
Closed
@fhinkel fhinkel deleted the ci-composer-test branch August 2, 2019 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ace-n ace-n ace-n approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leahecole @ace-n @googlebot @kokoro-team