Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Healthcare API Fhir sample #835

Merged
merged 3 commits into from
Nov 8, 2018
Merged

Add Healthcare API Fhir sample #835

merged 3 commits into from
Nov 8, 2018

Conversation

noerog
Copy link
Contributor

@noerog noerog commented Nov 8, 2018

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2018
@fhinkel fhinkel changed the title Chc api alpha fhir Add Healthcare API Fhir sample Nov 8, 2018
@fhinkel
Copy link
Contributor

fhinkel commented Nov 8, 2018

Do you want to rename the region tag to heathcare-fhir-...?

@noerog
Copy link
Contributor Author

noerog commented Nov 8, 2018

I think that it makes sense to do healthcare-fhir for the fhir_resources.js file, but in fhir_stores.js the region tags are already FHIR-specific (create_fhir_store, etc.).

… README. Update fhir_resources region tags to include fhir.
Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming tests pass locally. Thanks!

@fhinkel fhinkel merged commit cb3ba4d into GoogleCloudPlatform:master Nov 8, 2018
grayside pushed a commit that referenced this pull request Nov 11, 2022
* build!: update library to use Node 12
* build: fix broken Kokoro configuration test
* build: import version from package.json for tests
grayside pushed a commit that referenced this pull request Nov 11, 2022
🤖 I have created a release *beep* *boop*
---


## [5.0.0](googleapis/cloud-profiler-nodejs@v4.2.0...v5.0.0) (2022-06-20)


### ⚠ BREAKING CHANGES

* update library to use Node 12 (#835)

### Bug Fixes

* **deps:** update dependency @google-cloud/common to v4 ([#843](googleapis/cloud-profiler-nodejs#843)) ([1af6b0f](googleapis/cloud-profiler-nodejs@1af6b0f))
* **deps:** update dependency @google-cloud/logging-min to v10 ([#838](googleapis/cloud-profiler-nodejs#838)) ([1120298](googleapis/cloud-profiler-nodejs@1120298))


### Build System

* update library to use Node 12 ([#835](googleapis/cloud-profiler-nodejs#835)) ([07221ef](googleapis/cloud-profiler-nodejs@07221ef))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 12, 2022
* build!: update library to use Node 12
* build: fix broken Kokoro configuration test
* build: import version from package.json for tests
ace-n pushed a commit that referenced this pull request Nov 12, 2022
🤖 I have created a release *beep* *boop*
---


## [5.0.0](googleapis/cloud-profiler-nodejs@v4.2.0...v5.0.0) (2022-06-20)


### ⚠ BREAKING CHANGES

* update library to use Node 12 (#835)

### Bug Fixes

* **deps:** update dependency @google-cloud/common to v4 ([#843](googleapis/cloud-profiler-nodejs#843)) ([1af6b0f](googleapis/cloud-profiler-nodejs@1af6b0f))
* **deps:** update dependency @google-cloud/logging-min to v10 ([#838](googleapis/cloud-profiler-nodejs#838)) ([1120298](googleapis/cloud-profiler-nodejs@1120298))


### Build System

* update library to use Node 12 ([#835](googleapis/cloud-profiler-nodejs#835)) ([07221ef](googleapis/cloud-profiler-nodejs@07221ef))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants