Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Healthcare API alpha DICOM samples and tests #838

Merged
merged 7 commits into from
Nov 10, 2018
Merged

Healthcare API alpha DICOM samples and tests #838

merged 7 commits into from
Nov 10, 2018

Conversation

noerog
Copy link
Contributor

@noerog noerog commented Nov 8, 2018

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2018
fhinkel
fhinkel reviewed Nov 9, 2018
View reviewed changes
Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, I'd like to avoid having binary files in the repo. Could we put them in a Storage bucket? You could make the bucket public and use node-fetch or request.get() to pull them for the tests.

@fhinkel fhinkel merged commit 622a5f4 into GoogleCloudPlatform:master Nov 10, 2018
@noerog noerog deleted the chc-api-dicom branch November 12, 2018 15:52
grayside pushed a commit that referenced this pull request Nov 11, 2022
@release-please
chore(main): release 5.0.0 (#839)
5c45307 
🤖 I have created a release *beep* *boop*
---


## [5.0.0](googleapis/cloud-profiler-nodejs@v4.2.0...v5.0.0) (2022-06-20)


### ⚠ BREAKING CHANGES

* update library to use Node 12 (#835)

### Bug Fixes

* **deps:** update dependency @google-cloud/common to v4 ([#843](googleapis/cloud-profiler-nodejs#843)) ([1af6b0f](googleapis/cloud-profiler-nodejs@1af6b0f))
* **deps:** update dependency @google-cloud/logging-min to v10 ([#838](googleapis/cloud-profiler-nodejs#838)) ([1120298](googleapis/cloud-profiler-nodejs@1120298))


### Build System

* update library to use Node 12 ([#835](googleapis/cloud-profiler-nodejs#835)) ([07221ef](googleapis/cloud-profiler-nodejs@07221ef))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 12, 2022
@release-please
chore(main): release 5.0.0 (#839)
48ae058 
🤖 I have created a release *beep* *boop*
---


## [5.0.0](googleapis/cloud-profiler-nodejs@v4.2.0...v5.0.0) (2022-06-20)


### ⚠ BREAKING CHANGES

* update library to use Node 12 (#835)

### Bug Fixes

* **deps:** update dependency @google-cloud/common to v4 ([#843](googleapis/cloud-profiler-nodejs#843)) ([1af6b0f](googleapis/cloud-profiler-nodejs@1af6b0f))
* **deps:** update dependency @google-cloud/logging-min to v10 ([#838](googleapis/cloud-profiler-nodejs#838)) ([1120298](googleapis/cloud-profiler-nodejs@1120298))


### Build System

* update library to use Node 12 ([#835](googleapis/cloud-profiler-nodejs#835)) ([07221ef](googleapis/cloud-profiler-nodejs@07221ef))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@telpirion telpirion mentioned this pull request Nov 16, 2022
Merged
telpirion pushed a commit that referenced this pull request Nov 16, 2022
@JustinBeckwith
docs(samples): modernize the samples (#838)
2feefa4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noerog @fhinkel @googlebot