Drop support for Python 3.9 #406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It does not appear possible to use Python 3.13 using our maximum supported Astropy version. I don't think it's worth trying to understand why; we have no mandate to support 3.13 yet. So instead I have explicitly dropped support for Python 3.13+ in I have also regenerated our lock file ( |
tchamberlin
force-pushed
the
drop_py_39
branch
from
8d4c4df
to
1c408fa
Compare
tchamberlin
changed the title
mpound
reviewed
Oct 16, 2024
| @@ -95,7 +91,7 @@ cov = "pytest --cov-report=xml --cov-config=pyproject.toml --cov=src/dysh --cov= | |||
|
|
|||
| # Run tests across all supported version of Python | |||
| [[tool.hatch.envs.test.matrix]] | |||
| python = ["39", "310", "311", "312"] | |||
| python = ["310", "311", "312", "313"] | |||
There was a problem hiding this comment.
Should 313 be removed here?
There was a problem hiding this comment.
I think something got reverted during the rebase onto main. Will look tomorrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
specutils has dropped support for Python 3.9. So, we will do the same
Note that per this spec, https://scientific-python.org/specs/spec-0000/ , we should drop support for Python 3.10 as of Q4 2024 (now). But I don't see any good reason for doing that, as it isn't really adding any maintenance burden and I haven't heard anyone clamoring for new 3.10+ specific features yet