feat!: rename WITH parameter ENDPOINT_URL to ENDPOINT (#1904)

* feat!: rename WITH parameter ENDPOINT_URL to ENDPOINT * fix: typo
GreptimeTeam · Jul 7, 2023 · 6dd24f4 · 6dd24f4
1 parent 55500b7
commit 6dd24f4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/docs/rfcs/2023-07-06-table-engine-refactor.md b/docs/rfcs/2023-07-06-table-engine-refactor.md
@@ -131,7 +131,7 @@ region3-->RegionManifest3
 This RFC proposes to refactor table engines into region engines as a first step to make the `Datanode` acts like a `RegionServer`.
 
 
-# Detials
+# Details
 ## Overview
 
 We plan to refactor the `TableEngine` trait into `RegionEngine` gradually. This RFC focuses on the `mito` engine as it is the default table engine and the most complicated engine.

diff --git a/src/common/datasource/src/object_store/s3.rs b/src/common/datasource/src/object_store/s3.rs
@@ -20,7 +20,7 @@ use snafu::ResultExt;
 
 use crate::error::{self, Result};
 
-const ENDPOINT_URL: &str = "endpoint_url";
+const ENDPOINT: &str = "endpoint";
 const ACCESS_KEY_ID: &str = "access_key_id";
 const SECRET_ACCESS_KEY: &str = "secret_access_key";
 const SESSION_TOKEN: &str = "session_token";
@@ -36,7 +36,7 @@ pub fn build_s3_backend(
 
     let _ = builder.root(path).bucket(host);
 
-    if let Some(endpoint) = connection.get(ENDPOINT_URL) {
+    if let Some(endpoint) = connection.get(ENDPOINT) {
         let _ = builder.endpoint(endpoint);
     }