Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: rename WITH parameter ENDPOINT_URL to ENDPOINT #1904

Merged
merged 2 commits into from
Jul 7, 2023
Merged

feat!: rename WITH parameter ENDPOINT_URL to ENDPOINT #1904

merged 2 commits into from
Jul 7, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jul 7, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

rename WITH parameter ENDPOINT_URL to ENDPOINT

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@WenyXu WenyXu added the breaking-change This pull request contains breaking changes. label Jul 7, 2023
fengjiachun
fengjiachun approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

killme2008
killme2008 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 merged commit 6dd24f4 into GreptimeTeam:develop Jul 7, 2023
15 checks passed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@WenyXu @paomian
feat!: rename WITH parameter ENDPOINT_URL to ENDPOINT (GreptimeTeam#1904
e37cc19 
)

* feat!: rename WITH parameter ENDPOINT_URL to ENDPOINT

* fix: typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killme2008 killme2008 killme2008 approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

@MichaelScofield MichaelScofield Awaiting requested review from MichaelScofield

Assignees
No one assigned
Labels
breaking-change This pull request contains breaking changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WenyXu @killme2008 @fengjiachun