feat: push all possible filters down to parquet exec #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0y4g3r
commented
Jun 27, 2023
Codecov Report
@@ Coverage Diff @@
## develop #1839 +/- ##
===========================================
- Coverage 86.51% 86.28% -0.24%
===========================================
Files 588 589 +1
Lines 95768 95988 +220
===========================================
- Hits 82857 82822 -35
- Misses 12911 13166 +255 |
v0y4g3r
force-pushed
the
feat/filter-pushdown
branch
from
52566f3
to
ace7b8b
Compare
evenyag
reviewed
Jun 28, 2023
v0y4g3r
force-pushed
the
feat/filter-pushdown
branch
from
7ebb884
to
54c8c1b
Compare
v0y4g3r
force-pushed
the
feat/filter-pushdown
branch
from
ee2215f
to
e0bb142
Compare
v0y4g3r
force-pushed
the
feat/filter-pushdown
branch
from
e0bb142
to
78bc5e1
Compare
v0y4g3r
force-pushed
the
feat/filter-pushdown
branch
from
78bc5e1
to
9c4ec61
Compare
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: push all possible filters down to parquet exec * fix: project * test: add ut for DatafusionArrowPredicate * fix: according to CR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR pushes all possible filters down to Parquet exec to improve scan efficiency. Also this PR coerces time range predicate data types to timestamp type in storage schemas to address #992
Future work
Checklist
Refer to a related PR or issue link (optional)
Fixes #992