Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: rename WITH parameter ENDPOINT_URL to ENDPOINT #1904

Merged
merged 2 commits into from
Jul 7, 2023
Merged

feat!: rename WITH parameter ENDPOINT_URL to ENDPOINT #1904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a8f495
feat!: rename WITH parameter ENDPOINT_URL to ENDPOINT
WenyXu Jul 7, 2023
9f96f29
fix: typo
WenyXu Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/rfcs/2023-07-06-table-engine-refactor.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ region3-->RegionManifest3
This RFC proposes to refactor table engines into region engines as a first step to make the `Datanode` acts like a `RegionServer`.


# Detials
# Details
## Overview

We plan to refactor the `TableEngine` trait into `RegionEngine` gradually. This RFC focuses on the `mito` engine as it is the default table engine and the most complicated engine.
Expand Down
4 changes: 2 additions & 2 deletions src/common/datasource/src/object_store/s3.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ use snafu::ResultExt;

use crate::error::{self, Result};

const ENDPOINT_URL: &str = "endpoint_url";
const ENDPOINT: &str = "endpoint";
const ACCESS_KEY_ID: &str = "access_key_id";
const SECRET_ACCESS_KEY: &str = "secret_access_key";
const SESSION_TOKEN: &str = "session_token";
Expand All @@ -36,7 +36,7 @@ pub fn build_s3_backend(

let _ = builder.root(path).bucket(host);

if let Some(endpoint) = connection.get(ENDPOINT_URL) {
if let Some(endpoint) = connection.get(ENDPOINT) {
let _ = builder.endpoint(endpoint);
}

Expand Down