Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: json_path_exists udf #4807

Merged
merged 3 commits into from
Oct 10, 2024
Merged

feat: json_path_exists udf #4807

merged 3 commits into from
Oct 10, 2024

Conversation

CookiePieWw
Copy link
Collaborator

@CookiePieWw CookiePieWw commented Oct 9, 2024 •
edited by WenyXu
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#4805

What's changed and what's your intention?

As title.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@CookiePieWw CookiePieWw requested a review from a team as a code owner October 9, 2024 09:38
@github-actions github-actions bot added the docs-required This change requires docs update. label Oct 9, 2024
@github-actions github-actions bot added docs-not-required This change does not impact docs. and removed docs-required This change requires docs update. labels Oct 10, 2024
@WenyXu WenyXu mentioned this pull request Oct 10, 2024
Open
@github-actions github-actions bot added docs-required This change requires docs update. and removed docs-not-required This change does not impact docs. labels Oct 10, 2024
WenyXu
WenyXu approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM

@github-actions github-actions bot added docs-not-required This change does not impact docs. and removed docs-required This change requires docs update. labels Oct 10, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.15842% with 16 lines in your changes missing coverage. Please review.

Project coverage is 84.17%. Comparing base (0dd11f5) to head (c5a4c66).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4807      +/-   ##
==========================================
- Coverage   84.42%   84.17%   -0.26%     
==========================================
  Files        1123     1125       +2     
  Lines      204648   204860     +212     
==========================================
- Hits       172784   172435     -349     
- Misses      31864    32425     +561

@WenyXu WenyXu added this pull request to the merge queue Oct 10, 2024
Merged via the queue into GreptimeTeam:main with commit 288fdc3 Oct 10, 2024
33 checks passed
@Kev1n8 Kev1n8 mentioned this pull request Oct 22, 2024
Merged
3 tasks
@CookiePieWw CookiePieWw deleted the json_path_exists branch October 24, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paomian paomian paomian approved these changes

@WenyXu WenyXu WenyXu approved these changes

@shuiyisong shuiyisong Awaiting requested review from shuiyisong

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CookiePieWw @paomian @WenyXu