Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphql 2.3.8 removes "warden", breaking schema composition etc #276

Open
lyricsboy opened this issue Jul 15, 2024 · 0 comments · May be fixed by #278 or #282
Open

graphql 2.3.8 removes "warden", breaking schema composition etc #276

lyricsboy opened this issue Jul 15, 2024 · 0 comments · May be fixed by #278 or #282

Comments

@lyricsboy
Copy link

A change released in the 2.3.8 version of graphql removed the warden definition from a number of places, including this one:

rmosolgo/graphql-ruby@v2.3.7...v2.3.8#diff-e9dd0d295a58b66fabd1cf717040de5a78ade0feac6aeabae5247b5785c029ab

It looks like the internal usage of warden was replaced with types in many cases. This is documented in the release notes, but not as a breaking change.

This is manifesting for us in CI builds as an error like the following:

/mnt/ramdisk/vendor/bundle/ruby/3.2.0/gems/apollo-federation-3.8.5/lib/apollo-federation/federated_document_from_schema_definition.rb:83:in `query_type?': undefined local variable or method `warden' for #<ApolloFederation::FederatedDocumentFromSchemaDefinition...

      type == warden.root_type_for_operation('query')
              ^^^^^^
Did you mean?  warn
        from /mnt/ramdisk/vendor/bundle/ruby/3.2.0/gems/apollo-federation-3.8.5/lib/apollo-federation/federated_document_from_schema_definition.rb:71:in `block in build_type_definition_nodes'
        from /mnt/ramdisk/vendor/bundle/ruby/3.2.0/gems/apollo-federation-3.8.5/lib/apollo-federation/federated_document_from_schema_definition.rb:70:in `select'
        from /mnt/ramdisk/vendor/bundle/ruby/3.2.0/gems/apollo-federation-3.8.5/lib/apollo-federation/federated_document_from_schema_definition.rb:70:in `build_type_definition_nodes'
        from /mnt/ramdisk/vendor/bundle/ruby/3.2.0/gems/graphql-2.3.8/lib/graphql/language/document_from_schema_definition.rb:262:in `build_definition_nodes'
        from /mnt/ramdisk/vendor/bundle/ruby/3.2.0/gems/graphql-2.3.8/lib/graphql/language/document_from_schema_definition.rb:33:in `document'
@camero2734 camero2734 linked a pull request Aug 12, 2024 that will close this issue
Open
jeantessier added a commit to jeantessier/book-reviews that referenced this issue Aug 15, 2024
@jeantessier
Upgrade dependencies
177a237 
    for service in books reviews users search signatures jwts
    do
        echo '==========' $service '=========='
        (cd $service; bundle update --all)
    done
    echo '========== gateway =========='
    (cd gateway; npm update)

!!!  BROKEN  !!!  BROKEN  !!!  BROKEN  !!!  BROKEN  !!!  BROKEN  !!!

It updated the `graphql` gem, but it still uses the same version of
the `apollo-federation` gem.  I might have to wait for that one to
get an upgrade before things start working again.

See Gusto/apollo-federation-ruby#276
and Gusto/apollo-federation-ruby#278
@Bajena Bajena linked a pull request Sep 10, 2024 that will close this issue
Open
jeantessier added a commit to jeantessier/book-reviews that referenced this issue Sep 15, 2024
@jeantessier
Update dependencies
ebbc684 
    ./update.sh

Still broken.  Waiting on Gusto/apollo-federation-ruby#276
jeantessier added a commit to jeantessier/book-reviews that referenced this issue Nov 10, 2024
@jeantessier
Upgrade Rails 7.2.2. --> 8.0.0
4d5c174 
for service in books reviews users search signatures jwts
do
    echo '==========' $service '=========='
    (
        cd $service
        # Edit Gemfile to push Rails dependency to "~> 8"
        bundle update --bundler
        bundle update --all
        bin/rails app:update
        # Fix PORT in development.rb
        # Fix PORT in puma.rb
    )
done

Still broken.  Waiting on Gusto/apollo-federation-ruby#276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@lyricsboy