fix: Warden no longer available in latest graphql gem versions #278
Conversation
for service in books reviews users search signatures jwts
do
echo '==========' $service '=========='
(cd $service; bundle update --all)
done
echo '========== gateway =========='
(cd gateway; npm update)
!!! BROKEN !!! BROKEN !!! BROKEN !!! BROKEN !!! BROKEN !!!
It updated the `graphql` gem, but it still uses the same version of
the `apollo-federation` gem. I might have to wait for that one to
get an upgrade before things start working again.
See Gusto/apollo-federation-ruby#276
and Gusto/apollo-federation-ruby#278
|
🙏 We're running into issues with |
|
This is blocking our upgrade of graphql-ruby as well. 🙇 Would be very grateful for a resolution on this one soon, anything else needed to get this moving forward? |
|
I've made an experiment where I forked this repo and made it run with the latest graphql-ruby package. I discovered there are many other problems par this one. If we are able to fix them, we can open a PR upstream. Here's an example of the test run https://app.circleci.com/pipelines/github/productboardlabs/apollo-federation-ruby/4/workflows/b750a570-c50b-41f6-b658-10c91871e1bc/jobs/88 |
|
FYI: It seems that I managed to fix it "properly" in https://github.com/Gusto/apollo-federation-ruby/pull/282/files#diff-713da7628fd274d64409afdd877545f73256f9e15b7e120abc8dfcf8dbe8bfc7. |
Fixes #276
As explained in the issue, in the latest versions of
graphql, thewardenobject is no longer available in most places.It's mostly replaced by
@types-- which I initially used in the first pass -- but since the warden object can still be constructed, doing so was the easiest route for backwards compatibility purposes.