feat: adds support for the @interfaceObject directive
#218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszkuc
reviewed
Jan 31, 2023
moonflare
force-pushed
the
add-fed-2.3-support
branch
from
b141d87
to
0fda4f7
Compare
|
@grxy can you help out with the review of this PR? |
grxy
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
This works great! If you could follow up with a PR to add the @key support you mentioned, that would be much appreciated. Also, for future PRs, it looks like you will need to allow Gusto CircleCI orbs so that you can run CI. See this build page for the failure that prevented it from running.
grxy
pushed a commit
that referenced
this pull request
Feb 21, 2023
# [3.4.0](v3.3.1...v3.4.0) (2023-02-21) ### Bug Fixes * address some lint violations ([#219](#219)) ([dcd11e9](dcd11e9)) ### Features * add support for the [@interface](https://github.com/interface)Object directive ([#218](#218)) ([c7b987d](c7b987d))
|
🎉 This PR is included in version 3.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This was referenced Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The Apollo team are working on a new release for the Federation spec. This release will bump the spec to
v2.3and one of the main features is the support for referencing Entities that are interfaces. You can read more about this here, and check the initial implementation here.Description
In this PR I'm addressing two minor things:
@interfaceObjectfor theObjectclassv2.3@link(url: "https://specs.apollo.dev/federation/v2.3", as: "fed2"))Considerations
v2.3is that we can't apply@keydirective on interfaces for versions lower thanv2.3. Also, if we do (inv2.3+), we need to make sure all the implementing types also have the@keydirective. (According to this)Regarding the consideration above, let me know if you think it makes sense to add it part of this PR or it can be added after we get this one in. Currently, we need the existing changes to support the new features in
v2.3, but I'm willing to add the extra validations so we have a consistent implementation of thev2.3spec support.