Make edm4dr an "extended datamodel" #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This profits from the recently added functionality in podio (AIDASoft/podio#317) and takes edm4hep::ObjectID from edm4hep proper. This avoids some warning and a possible deadlock in ROOT.
tmadlener
reviewed
Aug 3, 2022
edm4dr/CMakeLists.txt
Outdated
| # Use the EDM4HEP_DATA_DIR to derive extended data model | ||
| message(STATUS "${EDM4HEP_DATA_DIR}") | ||
| if ("${EDM4HEP_DATA_DIR}" STREQUAL "") | ||
| message(WARNING "Unable to extend data model since no installed yaml file found.") |
There was a problem hiding this comment.
In case of edm4dr this should probably be a hard failure once the yaml file has changed, right?
tmadlener
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
I suppose we are waiting for the nightly build to pick up key4hep/EDM4hep#164 to have working tests again. Otherwise, I don't see anything that is blocking this.
SanghyunKo
approved these changes
Aug 3, 2022
|
@vvolkl @tmadlener I pulled the staged PR on the Podio and ran a local test, and everything works well up to runtime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This profits from the recently added functionality in podio (AIDASoft/podio#317) and takes edm4hep::ObjectID from edm4hep proper. This avoids some warning and a possible deadlock in ROOT.