Removed h_neglect args from remapping_core_h() #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcroft
force-pushed
the
Hallberg-NOAA-non_opt_h_neglect
branch
from
5254fe6
to
e79a182
Compare
The API for remaping_core_h() should not have h_neglect as an argument, so converting it from optional to mandatory has moved things in the wrong direction. The better way to get the *truly optional* parameter into the remapping is as a parameter in the type. This commit implements that for the remapping type. In the "big" refactor, the parameters are further moved down to be associated with the actual reconstruction schemes.
adcroft
force-pushed
the
Hallberg-NOAA-non_opt_h_neglect
branch
from
e79a182
to
14c977c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API for remaping_core_h() should never had the h_neglect argument, so converting it from optional to mandatory has moved things in the wrong direction. The right way to get the truly optional parameter into the remapping is as a parameter in the type. This commit implements that for the remapping type. In the "big" refactor I'm working on, the parameters are further moved down to be associated with the actual reconstruction schemes.